Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1413703007: [Interpreter] Fix a register allocation bug and add a DCHECK. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix a register allocation bug and add a DCHECK. BUG=v8:4280 LOG=N Committed: https://crrev.com/f85c410626735669c20aa8ba5b78c4a254416cfc Cr-Commit-Position: refs/heads/master@{#31604}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 5 chunks +8 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413703007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413703007/1
5 years, 1 month ago (2015-10-27 12:04:47 UTC) #2
rmcilroy
Orion, PTAL, thanks.
5 years, 1 month ago (2015-10-27 12:04:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 12:28:50 UTC) #6
oth
lgtm, one minor suggestion. https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-array-builder.cc#newcode1064 src/interpreter/bytecode-array-builder.cc:1064: bool TemporaryRegisterScope::AllocatedRegister(Register reg) const { ...
5 years, 1 month ago (2015-10-27 12:30:23 UTC) #7
rmcilroy
https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-array-builder.cc#newcode1064 src/interpreter/bytecode-array-builder.cc:1064: bool TemporaryRegisterScope::AllocatedRegister(Register reg) const { On 2015/10/27 12:30:23, oth ...
5 years, 1 month ago (2015-10-27 13:13:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413703007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413703007/20001
5 years, 1 month ago (2015-10-27 13:13:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 13:33:15 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 13:33:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f85c410626735669c20aa8ba5b78c4a254416cfc
Cr-Commit-Position: refs/heads/master@{#31604}

Powered by Google App Engine
This is Rietveld 408576698