[Interpreter] Fix a register allocation bug and add a DCHECK.

[Interpreter] Fix a register allocation bug and add a DCHECK.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/f85c410626735669c20aa8ba5b78c4a254416cfc
Cr-Commit-Position: refs/heads/master@{#31604}

[rmcilroy, 2015-10-27 12:04:40]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 12:04:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413703007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413703007/1

[rmcilroy, 2015-10-27 12:04:58]

rmcilroy@chromium.org changed reviewers:
+ oth@chromium.org

[rmcilroy, 2015-10-27 12:04:58]

Orion, PTAL, thanks.

[commit-bot: I haz the power, 2015-10-27 12:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 12:28:50]

Dry run: This issue passed the CQ dry run.

[oth, 2015-10-27 12:30:23]

lgtm, one minor suggestion.

https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:1064: bool
TemporaryRegisterScope::AllocatedRegister(Register reg) const {
Suggest renaming to RegisterIsAllocated() to match other register property
methods.

[rmcilroy, 2015-10-27 13:13:24]

https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1413703007/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:1064: bool
TemporaryRegisterScope::AllocatedRegister(Register reg) const {
On 2015/10/27 12:30:23, oth wrote:
> Suggest renaming to RegisterIsAllocated() to match other register property
> methods.

Renamed to RegisterIsAllocatedInThisScope() to be super clear what it does :).

[rmcilroy, 2015-10-27 13:13:46]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-10-27 13:13:47]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1413703007/#ps20001
(title: "Rename function")

[commit-bot: I haz the power, 2015-10-27 13:13:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413703007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413703007/20001

[commit-bot: I haz the power, 2015-10-27 13:33:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-27 13:33:34]

Patchset 2 (id:??) landed as
https://crrev.com/f85c410626735669c20aa8ba5b78c4a254416cfc
Cr-Commit-Position: refs/heads/master@{#31604}