Issue 14137026: Defer slow branch of GetAlignedPointerFromInternalField

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14137026: Defer slow branch of GetAlignedPointerFromInternalField (Closed)

Created:
7 years, 8 months ago by dcarney

Modified:
7 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev, haraken, jochen (gone - plz use gerrit)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Defer slow branch of GetAlignedPointerFromInternalField BUG= Committed: https://code.google.com/p/v8/source/detail?r=14444

Patch Set 2 : addressed comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	include/v8.h	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with nits https://chromiumcodereview.appspot.com/14137026/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/14137026/diff/1/include/v8.h#newcode95 include/v8.h:95: #ifdef __GNUC__ An undefined preprocessor symbol ...

7 years, 8 months ago (2013-04-26 07:09:27 UTC) #2

dcarney

7 years, 8 months ago (2013-04-26 07:28:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14444 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14137026: Defer slow branch of GetAlignedPointerFromInternalField (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages