Add TechnologyState to NetworkStateHandler.

Add TechnologyState to NetworkStateHandler.

This introduces a local "enabling" state for technology and
adds UI for the intermittent state.

It will also make it easier to switch to Shill technology
states once those are implemented.

BUG=223986
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194233

[stevenjb, 2013-04-11 21:04:46]

rkc@ and gspencer@ - please especially check the logic in ToggleMobile (compare
it to NetworkMenu::ToggleMobile()). It will be a pain to check carefully, but
it's also going to be difficult to test and I don't want to screw it up :)

[Greg Spencer (Chromium), 2013-04-11 21:35:12]

https://codereview.chromium.org/14137017/diff/1/ash/system/chromeos/network/n...
File ash/system/chromeos/network/network_state_list_detailed_view.cc (right):

https://codereview.chromium.org/14137017/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_state_list_detailed_view.cc:854: // when
NetworkListDetailedView is dperecated. crbug.com/222540.
dperecated --> deprecated

https://codereview.chromium.org/14137017/diff/1/chromeos/network/network_stat...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/14137017/diff/1/chromeos/network/network_stat...
chromeos/network/network_state_handler.h:89: bool TechnologyEnabled(const
std::string& type) const {
Shouldn't this be named something like "IsTechnologyEnabled"?

https://codereview.chromium.org/14137017/diff/1/chromeos/network/network_stat...
chromeos/network/network_state_handler.h:253: std::string
TechnologyForType(const std::string& type) const;
Maybe GetTechnologyForType?  I think usually only the lower-case accessors are
named for the items they return rather than being a verb.

https://codereview.chromium.org/14137017/diff/1/chromeos/network/shill_proper...
File chromeos/network/shill_property_handler.h (right):

https://codereview.chromium.org/14137017/diff/1/chromeos/network/shill_proper...
chromeos/network/shill_property_handler.h:91: bool TechnologyAvailable(const
std::string& technology) const;
Same here... Shouldn't these all be IsTechnology...?

[stevenjb, 2013-04-15 18:49:32]

https://codereview.chromium.org/14137017/diff/1/ash/system/chromeos/network/n...
File ash/system/chromeos/network/network_state_list_detailed_view.cc (right):

https://codereview.chromium.org/14137017/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_state_list_detailed_view.cc:854: // when
NetworkListDetailedView is dperecated. crbug.com/222540.
On 2013/04/11 21:35:12, Greg Spencer (Chromium) wrote:
> dperecated --> deprecated

Done.

https://codereview.chromium.org/14137017/diff/1/chromeos/network/network_stat...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/14137017/diff/1/chromeos/network/network_stat...
chromeos/network/network_state_handler.h:89: bool TechnologyEnabled(const
std::string& type) const {
On 2013/04/11 21:35:12, Greg Spencer (Chromium) wrote:
> Shouldn't this be named something like "IsTechnologyEnabled"?

Done.

https://codereview.chromium.org/14137017/diff/1/chromeos/network/network_stat...
chromeos/network/network_state_handler.h:253: std::string
TechnologyForType(const std::string& type) const;
On 2013/04/11 21:35:12, Greg Spencer (Chromium) wrote:
> Maybe GetTechnologyForType?  I think usually only the lower-case accessors are
> named for the items they return rather than being a verb.

Done.

https://codereview.chromium.org/14137017/diff/1/chromeos/network/shill_proper...
File chromeos/network/shill_property_handler.h (right):

https://codereview.chromium.org/14137017/diff/1/chromeos/network/shill_proper...
chromeos/network/shill_property_handler.h:91: bool TechnologyAvailable(const
std::string& technology) const;
On 2013/04/11 21:35:12, Greg Spencer (Chromium) wrote:
> Same here... Shouldn't these all be IsTechnology...?

Done.

[Greg Spencer (Chromium), 2013-04-15 19:00:54]

LGTM

[stevenjb, 2013-04-15 21:09:29]

Committed patchset #3 manually as r194233 (presubmit successful).

[jennyz, 2013-04-15 21:13:00]

lgtm for ash.