Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 14137010: turn on pathops unit test (Closed)

Created:
7 years, 8 months ago by caryclark
Modified:
7 years, 8 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

turn on pathops unit test This temporarily disables SK_ENABLE_INST_COUNT ( skbug.com/1219 ) This fixes a linktime error on VS2012 in PathTest.cpp; -SK_ScalarInfinity should be SK_ScalarNegativeInfinity instead. This adds pathops and pathops unit tests to the main unit tests. Should this change destabilize anything, it should be sufficient to comment out the pathops gypi includes. at test.gyp:18,21. Committed: https://code.google.com/p/skia/source/detail?r=8644

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -94 lines) Patch
A gyp/pathops.gypi View 1 1 chunk +63 lines, -0 lines 0 comments Download
M gyp/pathops_unittest.gyp View 1 1 chunk +4 lines, -93 lines 0 comments Download
A gyp/pathops_unittest.gypi View 1 chunk +42 lines, -0 lines 0 comments Download
M gyp/tests.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tests/PathTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
caryclark
7 years, 8 months ago (2013-04-12 11:59:58 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r8644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698