Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413683006: Move runtime js files down to lib/runtime/dart (Closed)

Created:
5 years, 1 month ago by ochafik
Modified:
5 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move runtime js files down to lib/runtime/dart Prepare for writing all the runtime in Dart: - Move js runtime files to lib/runtime/dart (dart_runtime.js -> dart/_runtime.js), - Use rest params instead of arguments slicing in a couple of places. BUG=https://github.com/dart-lang/dev_compiler/issues/310 R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/38ebfc008ae396016214a83331058aedb5bfb1a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -2164 lines) Patch
D lib/runtime/_classes.js View 1 chunk +0 lines, -422 lines 0 comments Download
D lib/runtime/_errors.js View 1 chunk +0 lines, -41 lines 0 comments Download
D lib/runtime/_generators.js View 1 chunk +0 lines, -234 lines 0 comments Download
D lib/runtime/_operations.js View 1 chunk +0 lines, -466 lines 0 comments Download
D lib/runtime/_rtti.js View 1 chunk +0 lines, -182 lines 0 comments Download
D lib/runtime/_types.js View 1 chunk +0 lines, -546 lines 0 comments Download
A + lib/runtime/dart/_classes.js View 6 chunks +9 lines, -13 lines 0 comments Download
A + lib/runtime/dart/_errors.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/_foreign_helper.js View 1 chunk +1 line, -1 line 0 comments Download
A + lib/runtime/dart/_generators.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/_interceptors.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_internal.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_js_embedded_names.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_js_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_js_mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_js_primitives.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 1 chunk +1 line, -1 line 0 comments Download
A + lib/runtime/dart/_operations.js View 5 chunks +9 lines, -13 lines 0 comments Download
A + lib/runtime/dart/_rtti.js View 5 chunks +10 lines, -15 lines 0 comments Download
A + lib/runtime/dart/_runtime.js View 1 chunk +7 lines, -7 lines 0 comments Download
A + lib/runtime/dart/_types.js View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/async.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/collection.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/core.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/isolate.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/js.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/math.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/typed_data.js View 1 chunk +1 line, -1 line 0 comments Download
D lib/runtime/dart_runtime.js View 1 chunk +0 lines, -121 lines 0 comments Download
M lib/runtime/dart_utils.js View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/compiler.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M lib/src/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/browser/runtime_tests.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/codegen/expect/8invalid-chars.in+file_name.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/BenchmarkBase.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/DeltaBlue.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/async_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/async_helper/async_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/cascade.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/closure.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/algorithms.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/iterable_zip.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/priority_queue.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/queue_list.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/utils.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/wrappers.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/wrappers.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M test/codegen/expect/constructors.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/covariance.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dir/html_input_a.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dir/html_input_b.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dir/html_input_c.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dir/html_input_d.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dir/html_input_e.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dom/dom.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/domtest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/expect.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/expect/expect.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/fieldtest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/functions.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/html_input.html View 1 chunk +7 lines, -7 lines 0 comments Download
M test/codegen/expect/map_keys.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/methods.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/misc.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/names.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/opassign.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/script.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/circle.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/dom.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/painter.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 chunk +7 lines, -7 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/syncstar_syntax.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/temps.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/try_catch.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/unittest/unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 6 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ochafik
Hey John, here's a baby step to prepare the dart runtime switch
5 years, 1 month ago (2015-10-29 16:08:53 UTC) #3
Jennifer Messerly
lgtm!
5 years, 1 month ago (2015-10-29 16:30:24 UTC) #4
ochafik
5 years, 1 month ago (2015-10-29 16:44:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
38ebfc008ae396016214a83331058aedb5bfb1a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698