Add new, unused methods to SpdyFramerVisitorInterface.

Add new, unused methods to SpdyFramerVisitorInterface.

The new methods will allow SpdyFramer to pass headers to visitors through a
SpdyHeadersHandlerInterface.

There are so many descendants of SpdyFramerVisitorInterface that I thought it
was best to start with the interface change, and add an unused stub
implementation everywhere.

This CL lands server change 106411694 by birenroy.

BUG=488484
Committed: https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442
Cr-Commit-Position: refs/heads/master@{#357084}

Committed: https://crrev.com/4a9943c8a656e6a3397aae7b29f09b694a0066aa
Cr-Commit-Position: refs/heads/master@{#357345}

Committed: https://crrev.com/a28fe41614c449fcbbdf72a97d9acc297fab8ec2
Cr-Commit-Position: refs/heads/master@{#357624}

[Bence, 2015-10-29 18:14:37]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2015-10-29 18:14:37]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2015-10-29 20:00:11]

lgtm

[Bence, 2015-10-30 11:31:38]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-10-30 11:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413683005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413683005/1

[commit-bot: I haz the power, 2015-10-30 12:17:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-30 12:18:33]

Patchset 1 (id:??) landed as
https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442
Cr-Commit-Position: refs/heads/master@{#357084}

[Bence, 2015-10-30 13:45:25]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1422623009/ by bnc@chromium.org.

The reason for reverting is: This CL broke the tree:
https://build.chromium.org/p/chromium/builders/Linux/builds/68259/steps/compi...

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-z,now -Wl,-z,relro
-Wl,--fatal-warnings -Wl,-z,defs -pthread -Wl,-z,noexecstack -fPIC
-B/b/build/slave/Linux/build/src/third_party/binutils/Linux_x64/Release/bin
-Wl,--disable-new-dtags -m32 -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -o
flip_in_mem_edsm_server -Wl,--start-group
obj/net/tools/flip_server/flip_in_mem_edsm_server.flip_in_mem_edsm_server.o
obj/base/libbase.a obj/net/libflip_in_mem_edsm_server_base.a obj/net/libnet.a
obj/base/libbase_static.a obj/base/allocator/liballocator_extension_thunks.a
obj/third_party/modp_b64/libmodp_b64.a
obj/base/third_party/dynamic_annotations/libdynamic_annotations.a
obj/base/libsymbolize.a obj/base/libxdg_mime.a
obj/third_party/libevent/libevent.a obj/third_party/boringssl/libboringssl.a
obj/net/libbalsa.a obj/base/libbase_i18n.a obj/third_party/icu/libicui18n.a
obj/third_party/icu/libicuuc.a obj/third_party/protobuf/libprotobuf_lite.a
obj/url/liburl_lib.a obj/net/libnet_quic_proto.a obj/base/libbase_prefs.a
obj/crypto/libcrcrypto.a obj/sdch/libsdch.a
obj/third_party/zlib/libchrome_zlib.a obj/third_party/zlib/libzlib_x86_simd.a
obj/build/linux/libgio.a obj/net/libepoll_server.a -Wl,--end-group  -lrt -ldl
-lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3
-lplds4 -lplc4 -lnspr4 -lgconf-2 -lgio-2.0 -lresolv
obj/net/libflip_in_mem_edsm_server_base.a(obj/net/tools/flip_server/flip_in_mem_edsm_server_base.spdy_interface.o):../../net/tools/flip_server/spdy_interface.cc:vtable
for net::SpdySM: error: undefined reference to
'net::SpdySM::OnHeaderFrameStart(unsigned int)'
obj/net/libflip_in_mem_edsm_server_base.a(obj/net/tools/flip_server/flip_in_mem_edsm_server_base.spdy_interface.o):../../net/tools/flip_server/spdy_interface.cc:vtable
for net::SpdySM: error: undefined reference to
'net::SpdySM::OnHeaderFrameEnd(unsigned int, bool)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
.

[Bence, 2015-10-30 13:46:42]

Kudos for kjellander@ for pointing out the build failure to me and for asking me
before reverting.

[Bence, 2015-10-30 15:24:13]

Description was changed from

==========
Add new, unused methods to SpdyFramerVisitorInterface.

The new methods will allow SpdyFramer to pass headers to visitors through a
SpdyHeadersHandlerInterface.

There are so many descendants of SpdyFramerVisitorInterface that I thought it
was best to start with the interface change, and add an unused stub
implementation everywhere.

This CL lands server change 106411694 by birenroy.

BUG=488484

Committed: https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442
Cr-Commit-Position: refs/heads/master@{#357084}
==========

to

==========
Add new, unused methods to SpdyFramerVisitorInterface.

The new methods will allow SpdyFramer to pass headers to visitors through a
SpdyHeadersHandlerInterface.

There are so many descendants of SpdyFramerVisitorInterface that I thought it
was best to start with the interface change, and add an unused stub
implementation everywhere.

This CL lands server change 106411694 by birenroy.

BUG=488484

Committed: https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442
Cr-Commit-Position: refs/heads/master@{#357084}
==========

[Bence, 2015-10-30 15:30:51]

Ryan: PTAL.  Patch Set 1 passed CQ but broke the build, I reverted then
re-opened.  I was able to reproduce compile errors locally when building
flip_in_mem_edsm_server target, and fixed them by adding dummy implementation in
flip_server.cc.

[Ryan Hamilton, 2015-10-30 22:07:11]

lgtm

[Bence, 2015-11-02 12:07:00]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-11-02 12:07:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413683005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413683005/40001

[commit-bot: I haz the power, 2015-11-02 13:39:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-02 13:40:23]

Patchset 3 (id:??) landed as
https://crrev.com/4a9943c8a656e6a3397aae7b29f09b694a0066aa
Cr-Commit-Position: refs/heads/master@{#357345}

[Bence, 2015-11-02 14:31:08]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1419923003/ by bnc@chromium.org.

The reason for reverting is: Breaks compilation of
flip_in_mem_edsm_server_unittests target.

https://build.chromium.org/p/chromium/builders/Linux/builds/68316/steps/compi...

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/net/tools/flip_server/flip_in_mem_edsm_server_unittests.spdy_interface_test.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64
-DCHROMIUM_BUILD -DCR_CLANG_REVISION=247874-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT
-DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1
-DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA
-DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PDF=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1
-DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DGTEST_HAS_POSIX_RE=0
-DGTEST_LANG_CXX11=0 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DUSE_LIBPCI=1
-DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-Igen -I../../testing/gtest/include -I../../testing/gmock/include
-I../../third_party/boringssl/src/include -I../.. -fstack-protector
--param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang
/b/build/slave/Linux/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates
-momit-leaf-frame-pointer -mstack-alignment=16 -mstackrealign
-fcolor-diagnostics
-B/b/build/slave/Linux/build/src/third_party/binutils/Linux_x64/Release/bin
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-bitfield-width -pthread -I/usr/include/glib-2.0
-I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/nss
-I/usr/include/nspr -Wno-header-guard -msse2 -mfpmath=sse -mmmx -m32 -O2
-fno-ident -fdata-sections -ffunction-sections -funwind-tables -fno-exceptions
-fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare
-std=gnu++11  -c ../../net/tools/flip_server/spdy_interface_test.cc -o
obj/net/tools/flip_server/flip_in_mem_edsm_server_unittests.spdy_interface_test.o
../../net/tools/flip_server/spdy_interface_test.cc:165:36: error: allocating an
object of abstract class type 'net::(anonymous namespace)::SpdyFramerVisitor'
    spdy_framer_visitor_.reset(new SpdyFramerVisitor);
                                   ^
../../net/spdy/buffered_spdy_framer.h:86:40: note: unimplemented pure virtual
method 'OnHeaderFrameStart' in 'SpdyFramerVisitor'
  virtual SpdyHeadersHandlerInterface* OnHeaderFrameStart(
                                       ^
../../net/spdy/buffered_spdy_framer.h:92:16: note: unimplemented pure virtual
method 'OnHeaderFrameEnd' in 'SpdyFramerVisitor'
  virtual void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) = 0;
               ^
1 error generated.
.

[Bence, 2015-11-02 14:47:22]

Description was changed from

==========
Add new, unused methods to SpdyFramerVisitorInterface.

The new methods will allow SpdyFramer to pass headers to visitors through a
SpdyHeadersHandlerInterface.

There are so many descendants of SpdyFramerVisitorInterface that I thought it
was best to start with the interface change, and add an unused stub
implementation everywhere.

This CL lands server change 106411694 by birenroy.

BUG=488484

Committed: https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442
Cr-Commit-Position: refs/heads/master@{#357084}

Committed: https://crrev.com/4a9943c8a656e6a3397aae7b29f09b694a0066aa
Cr-Commit-Position: refs/heads/master@{#357345}
==========

to

==========
Add new, unused methods to SpdyFramerVisitorInterface.

The new methods will allow SpdyFramer to pass headers to visitors through a
SpdyHeadersHandlerInterface.

There are so many descendants of SpdyFramerVisitorInterface that I thought it
was best to start with the interface change, and add an unused stub
implementation everywhere.

This CL lands server change 106411694 by birenroy.

BUG=488484

Committed: https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442
Cr-Commit-Position: refs/heads/master@{#357084}

Committed: https://crrev.com/4a9943c8a656e6a3397aae7b29f09b694a0066aa
Cr-Commit-Position: refs/heads/master@{#357345}
==========

[Bence, 2015-11-02 14:49:52]

Ryan: please take yet another look.  Thanks.

Turns out patch set 3 indeed fixed compilation errors with
flip_in_mem_edsm_server, but not with flip_in_mem_edsm_server_unittests.  I
locally verified that flip_in_mem_edsm_server_unittests now builds with patch
set 4.  Note that tests have already been failing before this CL.  (Apparently
continuous builders don't care about these tests passing as long as they
compile.  Maybe time to deprecate flip_server?)

[Ryan Hamilton, 2015-11-03 18:58:36]

lgtm

[Bence, 2015-11-03 19:35:43]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-11-03 19:39:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413683005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413683005/60001

[commit-bot: I haz the power, 2015-11-03 21:14:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-03 21:15:20]

Patchset 4 (id:??) landed as
https://crrev.com/a28fe41614c449fcbbdf72a97d9acc297fab8ec2
Cr-Commit-Position: refs/heads/master@{#357624}