src/gpu/effects/GrConfigConversionEffect.cpp - Issue 1413673002: Remove DrawingMgr shims from GrContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConfigConversionEffect.cpp

Issue 1413673002: Remove DrawingMgr shims from GrContext (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove abandon, reset & flush from public DrawingMgr API Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConfigConversionEffect.cpp

diff --git a/src/gpu/effects/GrConfigConversionEffect.cpp b/src/gpu/effects/GrConfigConversionEffect.cpp

index 8acf727bbfc63aa8dafb2c0c82028e51e070c6d0..0df7a537f2720b5791b39bdeff2cde23cb5d6ba9 100644

--- a/src/gpu/effects/GrConfigConversionEffect.cpp

+++ b/src/gpu/effects/GrConfigConversionEffect.cpp

@@ -224,7 +224,8 @@ void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context

paint1.addColorFragmentProcessor(pmToUPM1);

- SkAutoTUnref<GrDrawContext> readDrawContext(context->drawContext(readTex->asRenderTarget()));

+ SkAutoTUnref<GrDrawContext> readDrawContext(

+ context->drawingMgr().drawContext(readTex->asRenderTarget()));

if (!readDrawContext) {

failed = true;

break;

@@ -240,7 +241,8 @@ void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context

paint2.addColorFragmentProcessor(upmToPM);

- SkAutoTUnref<GrDrawContext> tempDrawContext(context->drawContext(tempTex->asRenderTarget()));

+ SkAutoTUnref<GrDrawContext> tempDrawContext(

+ context->drawingMgr().drawContext(tempTex->asRenderTarget()));

if (!tempDrawContext) {

failed = true;

break;

@@ -253,7 +255,7 @@ void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context

paint3.addColorFragmentProcessor(pmToUPM2);

- readDrawContext.reset(context->drawContext(readTex->asRenderTarget()));

+ readDrawContext.reset(context->drawingMgr().drawContext(readTex->asRenderTarget()));

if (!readDrawContext) {

failed = true;

break;