Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1413663008: Revert of Prevent the Online Reauth window from opening twice. (Closed)

Created:
5 years, 2 months ago by anthonyvd
Modified:
5 years, 2 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prevent the Online Reauth window from opening twice. (patchset #2 id:20001 of https://codereview.chromium.org/1415743002/ ) Reason for revert: Reverting this as it caused Issue 545819 which would prevent people from unlocking profiles on canary Original issue's description: > Prevent the Online Reauth window from opening twice. > > BUG=534726 > TEST= > 1. Add a supervised user to Chrome > 2. From a regular profile, click on the avatar button and select > "Exit and Childlock" > 3. In the User Manager, click on the yellow triangle next to the > locked profile's name > 4. The Online Reauth window should open once, not open-close-reopen > > Committed: https://crrev.com/e020927c5d71942748f67c25c347d1355dd11135 > Cr-Commit-Position: refs/heads/master@{#355139} TBR=groby@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=534726 Committed: https://crrev.com/f01bd4ddfbdc27494c89299288ddde452d632ce1 Cr-Commit-Position: refs/heads/master@{#355532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
anthonyvd
Created Revert of Prevent the Online Reauth window from opening twice.
5 years, 2 months ago (2015-10-22 14:05:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413663008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413663008/1
5 years, 2 months ago (2015-10-22 14:05:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 14:06:06 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 14:06:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f01bd4ddfbdc27494c89299288ddde452d632ce1
Cr-Commit-Position: refs/heads/master@{#355532}

Powered by Google App Engine
This is Rietveld 408576698