Rework analyzed files support to use globs

Rework analyzed files support to use globs

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/879cf82b6b29fe3669d48e75a4ecb9bc6b7f8b3a

[Brian Wilkerson, 2015-11-02 16:12:55]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2015-11-02 16:12:55]

This change will enable us to send the globs to clients so that they know which
files to send to server for analysis.

[scheglov, 2015-11-02 16:27:49]

LGTM

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1469: if (new
Glob(pattern).matches(file.path)) {
I wonder if creating Glob instances might be a performance bottleneck during
initial analysis roots scan.

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right):

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:285:
patterns.add('/**/*.$extension');
Do we need two globs?
Wouldn't just one "/**/.*$extension" work for absolute paths?
Does it work on Windows?

[Brian Wilkerson, 2015-11-02 16:54:38]

PTAL

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1469: if (new
Glob(pattern).matches(file.path)) {
> I wonder if creating Glob instances might be a performance bottleneck during
> initial analysis roots scan.

It probably would be. I also realized that I'd forgotten to guard against
exceptions due to invalid glob patterns. I've reworked it.

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right):

https://codereview.chromium.org/1413643006/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:285:
patterns.add('/**/*.$extension');
> Do we need two globs?
> Wouldn't just one "/**/.*$extension" work for absolute paths?

Yes, I forgot that we always have an absolute path.

> Does it work on Windows?

According to the README for the glob package, yes. Globs are always specified
using a POSIX notation but will work on Windows if you pass the right path
context in when you create it (which I also forgot to do).

[scheglov, 2015-11-02 16:58:23]

LGTM

[Brian Wilkerson, 2015-11-03 15:11:34]

Committed patchset #2 (id:20001) manually as
879cf82b6b29fe3669d48e75a4ecb9bc6b7f8b3a (presubmit successful).