Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 141363002: Count DOMImplementation.hasFeature usage and cases where it returns false (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Count DOMImplementation.hasFeature usage and cases where it returns false This is in order to support the spec discussion: http://lists.w3.org/Archives/Public/www-dom/2014JanMar/0031.html http://lists.w3.org/Archives/Public/www-svg/2014Jan/0042.html BUG=335301 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165299

Patch Set 1 #

Total comments: 2

Patch Set 2 : naming #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M Source/core/dom/DOMImplementation.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M Source/core/dom/DOMImplementation.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-17 01:46:18 UTC) #1
tkent
https://codereview.chromium.org/141363002/diff/1/Source/core/dom/DOMImplementation.idl File Source/core/dom/DOMImplementation.idl (right): https://codereview.chromium.org/141363002/diff/1/Source/core/dom/DOMImplementation.idl#newcode27 Source/core/dom/DOMImplementation.idl:27: [ImplementedAs=bindingsHasFeature, MeasureAs=DOMImplementationHasFeature] "ForBinding" suffix is more popular than "bindings" ...
6 years, 11 months ago (2014-01-17 01:59:05 UTC) #2
philipj_slow
https://codereview.chromium.org/141363002/diff/1/Source/core/dom/DOMImplementation.idl File Source/core/dom/DOMImplementation.idl (right): https://codereview.chromium.org/141363002/diff/1/Source/core/dom/DOMImplementation.idl#newcode27 Source/core/dom/DOMImplementation.idl:27: [ImplementedAs=bindingsHasFeature, MeasureAs=DOMImplementationHasFeature] On 2014/01/17 01:59:06, tkent wrote: > "ForBinding" ...
6 years, 11 months ago (2014-01-17 02:27:47 UTC) #3
tkent
lgtm
6 years, 11 months ago (2014-01-17 03:06:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/141363002/80001
6 years, 11 months ago (2014-01-17 03:06:50 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-17 03:06:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/141363002/130001
6 years, 11 months ago (2014-01-17 08:44:39 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 10:38:52 UTC) #8
Message was sent while issue was closed.
Change committed as 165299

Powered by Google App Engine
This is Rietveld 408576698