Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: net/url_request/url_request.h

Issue 1413623002: Convert 'CookieOptions::first_party_url' to a 'url::Origin'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_options.h ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.h
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index 9209697d0cfb377caa173c88184703770108f250..f685cf76e7bb23fe2c0f93b28c687cd61cacc71a 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -263,6 +263,11 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// a security check, an attacker might try to get around this check
// by starting from some page that redirects to the
// host-to-be-attacked.
+ //
+ // TODO(mkwst): Convert this to a 'url::Origin'. Several callsites are using
+ // this value as a proxy for the "top-level frame URL", which is simply
+ // incorrect and fragile. We don't need the full URL for any //net checks,
+ // so we should drop the pieces we don't need.
const GURL& first_party_for_cookies() const {
return first_party_for_cookies_;
}
« no previous file with comments | « net/cookies/cookie_options.h ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698