pkg/compiler/lib/src/universe/function_set.dart - Issue 1413613010: Normalize type masks to use the least upper instantiated subclass/type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/universe/function_set.dart

Issue 1413613010: Normalize type masks to use the least upper instantiated subclass/type. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/universe/class_set.dart ('K') | « pkg/compiler/lib/src/universe/class_set.dart ('k') | pkg/compiler/lib/src/universe/universe.dart » ('j') | tests/compiler/dart2js/type_mask2_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/universe/function_set.dart

diff --git a/pkg/compiler/lib/src/universe/function_set.dart b/pkg/compiler/lib/src/universe/function_set.dart

index 72a1813e91bc2fd22f13b005e1e6fb6901329c06..2f01f800c34f1958c784ff6dd7d89bfa7d82fb21 100644

--- a/pkg/compiler/lib/src/universe/function_set.dart

+++ b/pkg/compiler/lib/src/universe/function_set.dart

@@ -298,8 +298,10 @@ class FullFunctionSetQuery implements FunctionSetQuery {

.map((cls) {

if (classWorld.backend.isNullImplementation(cls)) {

return const TypeMask.empty();

- } else {

+ } else if (classWorld.isInstantiated(cls.declaration)) {

return new TypeMask.nonNullSubclass(cls.declaration, classWorld);

+ } else {

Johnni Winther 2015/11/03 13:20:02 Add TODO to avoid this.

Johnni Winther 2015/11/06 13:43:23 Done.

+ return const TypeMask.empty();

}

}),

classWorld);