third_party/WebKit/Source/platform/graphics/BitmapImage.cpp - Issue 1413593012: Record UMA stats for Blink decoded image orientation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

Issue 1413593012: Record UMA stats for Blink decoded image orientation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Different approach Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp b/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

index 2eb04ee146c4b639b00126f061ddef858ea2b9e4..4d9ec88233bc7cdbd61f27167a78a0b505d28542 100644

--- a/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

@@ -167,6 +167,7 @@ void BitmapImage::cacheFrame(size_t index)

m_frames[index].m_frame = m_source.createFrameAtIndex(index);

m_frames[index].m_orientation = m_source.orientationAtIndex(index);

+ Platform::current()->histogramEnumeration("Blink.DecodedImageOrientation", m_frames[index].m_orientation.orientation(), OriginLeftBottom + 1);

Noel Gordon 2015/11/10 01:14:56 The actual image orientation is not known until is

m_frames[index].m_haveMetadata = true;

m_frames[index].m_isComplete = m_source.frameIsCompleteAtIndex(index);

if (repetitionCount(false) != cAnimationNone)

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/ImageOrientation.h » ('j') | no next file with comments »