refractoring ImageBitmap class

third_party/WebKit/Source/core/frame/ImageBitmap.h

Index: third_party/WebKit/Source/core/frame/ImageBitmap.h
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.h b/third_party/WebKit/Source/core/frame/ImageBitmap.h
index 8dc3a51e7070dd73fd00cf08973306fd253b6a49..74cbb9c4978430d10751c85906d591fbd8bb954f 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.h
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.h
@@ -12,6 +12,7 @@
 #include "platform/geometry/IntRect.h"
 #include "platform/graphics/Image.h"
 #include "platform/heap/Handle.h"
+#include "third_party/skia/include/core/SkImage.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
@@ -32,8 +33,7 @@ public:
     static PassRefPtrWillBeRawPtr<ImageBitmap> create(ImageBitmap*, const IntRect&);
     static PassRefPtrWillBeRawPtr<ImageBitmap> create(Image*, const IntRect&);
 
-    PassRefPtr<Image> bitmapImage() const;
-    PassRefPtrWillBeRawPtr<HTMLImageElement> imageElement() const { return m_imageElement; }
+    PassRefPtr<SkImage> bitmapImage() const;

[Justin Novosad, 2015/10/30 14:35:19]

The name of this method refers to the class BitmapImage (a subclass of Image).
You should rename this method now.

[xidachen, 2015/10/30 15:32:35]

Done.

 
     IntRect bitmapRect() const { return m_bitmapRect; }
 
@@ -63,10 +63,7 @@ private:
     void notifyImageSourceChanged() override;
     bool requestsHighLiveResourceCachePriority() override { return true; }
 
-    // ImageBitmaps constructed from HTMLImageElements hold a reference to the HTMLImageElement until
-    // the image source changes.
-    RefPtrWillBeMember<HTMLImageElement> m_imageElement;
-    RefPtr<Image> m_bitmap;
+    RefPtr<SkImage> m_bitmap;
 
     IntRect m_bitmapRect; // The rect where the underlying Image should be placed in reference to the ImageBitmap.
     IntRect m_cropRect;

[Justin Novosad, 2015/10/30 14:35:19]

I think we can get rid of this now that we use SkImage::newSubset for cropping?

[xidachen, 2015/10/30 15:32:35]

I think this variable is used to store the size of the ImageBitmap.

@@ -75,7 +72,6 @@ private:
     // ImageBitmaps constructed from HTMLImageElements reference the entire ImageResource and may have a non-zero bitmap offset.
     // ImageBitmaps not constructed from HTMLImageElements always pre-crop and store the image at (0, 0).
     IntPoint m_bitmapOffset;
-
 };
 
 } // namespace blink