Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp

Issue 1413583002: Make ElementShadow::youngestShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more tail -> head Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
diff --git a/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp b/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
index 19a728b3ef533f03ab0ed49c087a0c7eceed7eae..6a2429ea3b5639ae9f732565dd562c6cc3d7068c 100644
--- a/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
+++ b/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
@@ -68,7 +68,7 @@ void ChildFrameDisconnector::disconnectCollectedFrameOwners()
void ChildFrameDisconnector::collectFrameOwners(ElementShadow& shadow)
{
- for (ShadowRoot* root = shadow.youngestShadowRoot(); root; root = root->olderShadowRoot())
+ for (ShadowRoot* root = &shadow.youngestShadowRoot(); root; root = root->olderShadowRoot())
collectFrameOwners(*root);
}
@@ -82,7 +82,7 @@ static unsigned checkConnectedSubframeCountIsConsistent(Node& node)
count++;
if (ElementShadow* shadow = toElement(node).shadow()) {
- for (ShadowRoot* root = shadow->youngestShadowRoot(); root; root = root->olderShadowRoot())
+ for (ShadowRoot* root = &shadow->youngestShadowRoot(); root; root = root->olderShadowRoot())
count += checkConnectedSubframeCountIsConsistent(*root);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698