Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1413573006: Make GN --as=output relative to the root build directory. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
aizatsky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GN --as=output relative to the root build directory. The intended use for this parameter is to give files that can be passed to Ninja to compile. Ninja takes files relative to the root build directory. BUG=546127 Committed: https://crrev.com/1c010e5f6ccb6b5d65044500fb1f656d3f8b5d6b Cr-Commit-Position: refs/heads/master@{#355555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tools/gn/commands.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/commands.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 2 months ago (2015-10-22 04:27:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413573006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413573006/1
5 years, 2 months ago (2015-10-22 04:27:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 04:39:09 UTC) #6
aizatsky
lgtm Thanks for fixing this.
5 years, 2 months ago (2015-10-22 16:49:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413573006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413573006/1
5 years, 2 months ago (2015-10-22 16:50:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 16:54:09 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 16:54:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c010e5f6ccb6b5d65044500fb1f656d3f8b5d6b
Cr-Commit-Position: refs/heads/master@{#355555}

Powered by Google App Engine
This is Rietveld 408576698