Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1413573004: Set page height for printing tests. (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set page height for printing tests. Without this we'd fail to properly re-lay out the document when switching to print layout, because LayoutView::pageLogicalHeight() would be 0, which typically makes everyone believe that we're not paginated. Added a layout tree dump test for this (found no other way of testing this). Also have to rebaseline two existing tests, because the layout tree dump changes. The pixel results are unaffected, though. BUG=544786 R=leviw@chromium.org Committed: https://crrev.com/4ae57a7213e21f6fd32b81d619986a212470033a Cr-Commit-Position: refs/heads/master@{#355526}

Patch Set 1 #

Patch Set 2 : Rebaseline ALL THE THINGS! #

Patch Set 3 : Temporarily comment out old duplicate entries in TestExpectations, to please the bots #

Patch Set 4 : Trying to rebaseline manually using webkit-patch. I don't think it's complete. #

Patch Set 5 : Back out patch set 4 and mark tests with NeedsManualRebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 3 chunks +13 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/printing/forced-break-tree-dump-only-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/forced-break-tree-dump-only.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
mstensho (USE GERRIT)
Looks like I need to rebaseline more tests, but in the meantime, Levi, are you ...
5 years, 2 months ago (2015-10-21 15:04:43 UTC) #1
leviw_travelin_and_unemployed
Yeah, looks like there's at least one more test to rebase, but the change makes ...
5 years, 2 months ago (2015-10-21 15:41:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413573004/20001
5 years, 2 months ago (2015-10-21 18:36:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/129445)
5 years, 2 months ago (2015-10-21 19:31:20 UTC) #7
mstensho (USE GERRIT)
Thanks for reviewing, Levi. Looks like I have another problem here. See e.g. http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/129445/steps/webkit_lint%20%28with%20patch%29 webkit_lint ...
5 years, 2 months ago (2015-10-21 19:35:09 UTC) #8
leviw_travelin_and_unemployed
On 2015/10/21 at 19:35:09, mstensho wrote: > Thanks for reviewing, Levi. > > Looks like ...
5 years, 2 months ago (2015-10-21 21:29:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413573004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413573004/80001
5 years, 2 months ago (2015-10-22 10:49:54 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-22 11:40:35 UTC) #13
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/4ae57a7213e21f6fd32b81d619986a212470033a Cr-Commit-Position: refs/heads/master@{#355526}
5 years, 2 months ago (2015-10-22 11:41:44 UTC) #14
mstensho (USE GERRIT)
5 years, 2 months ago (2015-10-22 19:35:08 UTC) #15
Message was sent while issue was closed.
On 2015/10/21 21:29:50, leviw wrote:
> On 2015/10/21 at 19:35:09, mstensho wrote:
> > Looks like I have another problem here. See e.g.
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...
> > 
> > webkit_lint complains because TestExpectations already contained Windows
> 10-specific entries for the tests that I now want to rebaseline.
> > 
> > Any idea what to do?
> 
> You have a couple options. The easiest is probably just to land with
> "NeedsManualRebaseline" and do a follow-up with the new results. You may need
to
> comment the Win10 line out when you do it.
> 
> If you're not familiar, webkit-patch has a rebaseline mode that will grab the
> results from the bots. You could also download them directly from the trybots,
> but that's a pain in the ass so I wouldn't bother.

Thanks a lot for the info. This was fun. :) No, I didn't know about webkit-patch
and its ability to rebaseline, but it was a most enjoyable experience. OK, I'm
exaggerating, but thanks!

Powered by Google App Engine
This is Rietveld 408576698