Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 1413563009: enable analysis server cmdline instrumentation log file option (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/server/driver.dart
diff --git a/pkg/analysis_server/lib/src/server/driver.dart b/pkg/analysis_server/lib/src/server/driver.dart
index 1862b9ff4fbc677d5e08108d1797bbe27760917c..d71ed5bb062bc29de4b74ad389a0922ccc05b137 100644
--- a/pkg/analysis_server/lib/src/server/driver.dart
+++ b/pkg/analysis_server/lib/src/server/driver.dart
@@ -381,12 +381,14 @@ class Driver implements ServerStarter {
//
// Initialize the instrumentation service.
//
+ String logFilePath = results[INSTRUMENTATION_LOG_FILE];
if (instrumentationServer != null) {
- String filePath = results[INSTRUMENTATION_LOG_FILE];
- if (filePath != null) {
+ if (logFilePath != null) {
lukechurch 2015/10/23 19:28:35 The pattern here is a little hard to read. Could w
instrumentationServer = new MulticastInstrumentationServer(
- [instrumentationServer, new FileInstrumentationServer(filePath)]);
+ [instrumentationServer, new FileInstrumentationServer(logFilePath)]);
}
+ } else if (logFilePath != null) {
+ instrumentationServer = new FileInstrumentationServer(logFilePath);
}
InstrumentationService service =
new InstrumentationService(instrumentationServer);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698