enable analysis server cmdline instrumentation log file option

enable analysis server cmdline instrumentation log file option

this change allows instrumentation to be logged to a file that is specified on the command line when analysis server is started for both internal and external builds of the analysis server

R=lukechurch@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/33e6b737e8ecff2f4d913a0624e51b90d6692b84

[danrubel, 2015-10-23 16:06:43]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-10-23 16:07:56]

LGTM

[lukechurch, 2015-10-23 19:28:35]

lukechurch@google.com changed reviewers:
+ lukechurch@google.com

[lukechurch, 2015-10-23 19:28:35]

https://codereview.chromium.org/1413563009/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/server/driver.dart (right):

https://codereview.chromium.org/1413563009/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/driver.dart:386: if (logFilePath != null) {
The pattern here is a little hard to read. Could we clarify a bit by extracting
the common if.

if (logFilePath != null) {
  fileBasedServer = new FileInstrumentationServer(logFilePath);
  
  if (instrumentationServer != null) {
    ...... multicast CTOR
  } else { 
     instrumentationServer = fileBasedServer;
}

[danrubel, 2015-10-23 19:39:26]

On 2015/10/23 19:28:35, lukechurch wrote:
>
https://codereview.chromium.org/1413563009/diff/1/pkg/analysis_server/lib/src...
> File pkg/analysis_server/lib/src/server/driver.dart (right):
> 
>
https://codereview.chromium.org/1413563009/diff/1/pkg/analysis_server/lib/src...
> pkg/analysis_server/lib/src/server/driver.dart:386: if (logFilePath != null) {
> The pattern here is a little hard to read. Could we clarify a bit by
extracting
> the common if.
> 
> if (logFilePath != null) {
>   fileBasedServer = new FileInstrumentationServer(logFilePath);
>   
>   if (instrumentationServer != null) {
>     ...... multicast CTOR
>   } else { 
>      instrumentationServer = fileBasedServer;
> }

Code clean complete. PTAL

[lukechurch, 2015-10-23 19:40:52]

Thanks, that's much quicker for me to understand the logic.

LGTM

[danrubel, 2015-10-23 19:47:14]

Committed patchset #2 (id:20001) manually as
33e6b737e8ecff2f4d913a0624e51b90d6692b84 (presubmit successful).