Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1413563005: Reset CORS status upon re-initiating fetch of a stylesheet. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+prerender_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset CORS status upon re-initiating fetch of a stylesheet. When initiating a fetch of a potentially cross-origin stylesheet that's already fetching, reset the is-following-CORS flag along with clearing the loading resource. R=haraken,mkwst BUG=544690 Committed: https://crrev.com/53ab90724aca77dcd6ad912d023c282cdf4df117 Cr-Commit-Position: refs/heads/master@{#355306}

Patch Set 1 #

Total comments: 2

Patch Set 2 : adjust test a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
please take a look.
5 years, 2 months ago (2015-10-21 11:50:30 UTC) #2
haraken
LGTM, but I want to have japhet confirm.
5 years, 2 months ago (2015-10-21 13:47:41 UTC) #3
Mike West
LGTM % nit. https://codereview.chromium.org/1413563005/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html File third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html (right): https://codereview.chromium.org/1413563005/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html#newcode26 third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html:26: div1.appendChild(link1); Nit: Can you actually grab ...
5 years, 2 months ago (2015-10-21 14:14:04 UTC) #4
sof
https://codereview.chromium.org/1413563005/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html File third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html (right): https://codereview.chromium.org/1413563005/diff/1/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html#newcode26 third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted.html:26: div1.appendChild(link1); On 2015/10/21 14:14:04, Mike West (slow) wrote: > ...
5 years, 2 months ago (2015-10-21 15:17:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413563005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413563005/20001
5 years, 2 months ago (2015-10-21 15:17:50 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 16:18:53 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 16:19:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53ab90724aca77dcd6ad912d023c282cdf4df117
Cr-Commit-Position: refs/heads/master@{#355306}

Powered by Google App Engine
This is Rietveld 408576698