Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1413563004: Make IndexableObjectKind parameterized. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make IndexableObjectKind parameterized. LMK if this is a bad change. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e0636b183c4ab2a87b2d93198105c1413e3ea4d8

Patch Set 1 #

Patch Set 2 : Clean up IndexableElementKind. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M pkg/analysis_server/lib/plugin/index/index_core.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/index.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/indexable_element.dart View 1 5 chunks +16 lines, -17 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/indexable_file.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-18 18:58:02 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-19 13:49:01 UTC) #2
scheglov
5 years, 2 months ago (2015-10-19 17:13:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e0636b183c4ab2a87b2d93198105c1413e3ea4d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698