Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: tools/run-tests.py

Issue 1413563002: [test] Add new variant default set for exhaustive testing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index 2782a70806190990ddcb6001b4c715ac7cd47651..e63a40cfdf2a7ff3050b1b5841a03565ef28d993 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -83,6 +83,10 @@ TIMEOUT_DEFAULT = 60
VARIANTS = ["default", "stress", "turbofan", "nocrankshaft"]
+EXHAUSTIVE_VARIANTS = VARIANTS + [
+ # TODO(machenbach): Add always opt turbo variant.
+]
+
DEBUG_FLAGS = ["--nohard-abort", "--nodead-code-elimination",
"--nofold-constants", "--enable-slow-asserts",
"--debug-code", "--verify-heap"]
@@ -253,6 +257,9 @@ def BuildOptions():
default=False, dest="no_variants", action="store_true")
result.add_option("--variants",
help="Comma-separated list of testing variants: %s" % VARIANTS)
+ result.add_option("--exhaustive-variants",
+ default=False, action="store_true",
+ help="Use exhaustive set of default variants.")
result.add_option("--outdir", help="Base directory with compile output",
default="out")
result.add_option("--predictable",
@@ -337,6 +344,7 @@ def BuildbotToV8Mode(config):
def ProcessOptions(options):
global ALL_VARIANTS
+ global EXHAUSTIVE_VARIANTS
global VARIANTS
# Architecture and mode related stuff.
@@ -388,6 +396,11 @@ def ProcessOptions(options):
if options.novfp3:
options.extra_flags.append("--noenable-vfp3")
+ if options.exhaustive_variants:
+ # This is used on many bots. It includes a larger set of default variants.
+ # Other options for manipulating variants still apply afterwards.
+ VARIANTS = EXHAUSTIVE_VARIANTS
+
if options.msan:
VARIANTS = ["default"]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698