content/browser/web_contents/web_contents_impl.h - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add WebNavigationApiTest.CrossProcessIframe test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 917a7342270e1448636d8578a9822a172f52b100..2d5453ea6176175ee8ad5ce7d4d3339c7dd42d10 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -234,6 +234,7 @@ class CONTENT_EXPORT WebContentsImpl

RenderProcessHost* GetRenderProcessHost() const override;

RenderFrameHostImpl* GetMainFrame() override;

RenderFrameHostImpl* GetFocusedFrame() override;

+ RenderFrameHostImpl* FindByFrameTreeNodeID(int frame_tree_node_id) override;

void ForEachFrame(

const base::Callback<void(RenderFrameHost*)>& on_frame) override;

void SendToAllFrames(IPC::Message* message) override;