content/public/browser/resource_request_info.h - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/resource_request_info.h

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/runs/that runs/ + public copy cons. to avoid compiler error Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/resource_request_info.h

diff --git a/content/public/browser/resource_request_info.h b/content/public/browser/resource_request_info.h

index e65bce062848fc401f860b40d7b44e249530e831..d5ee296b659f6b4966fe55ff341bdf69785c43ed 100644

--- a/content/public/browser/resource_request_info.h

+++ b/content/public/browser/resource_request_info.h

@@ -94,13 +94,9 @@ class ResourceRequestInfo {

// True if GetRenderFrameID() represents a main frame in the RenderView.

virtual bool IsMainFrame() const = 0;

- // True if GetParentRenderFrameID() represents a main frame in the RenderView.

+ // True if the frame's parent represents a main frame in the RenderView.

virtual bool ParentIsMainFrame() const = 0;

- // Routing ID of parent frame of frame that sent this resource request.

- // -1 if unknown / invalid.

- virtual int GetParentRenderFrameID() const = 0;

// Returns the associated resource type.

virtual ResourceType GetResourceType() const = 0;