content/browser/loader/resource_dispatcher_host_unittest.cc - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call callbacks ASAP, only use cache for GetFrameIdOnIO Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/resource_dispatcher_host_unittest.cc

diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc

index d7b2b17343c9c260b9cf8069ee31fe747c9a256f..852ee6d8d56673ac9872fa3641207c8368d09bda 100644

--- a/content/browser/loader/resource_dispatcher_host_unittest.cc

+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc

@@ -151,7 +151,6 @@ static ResourceHostMsg_Request CreateResourceRequest(const char* method,

request.should_reset_appcache = false;

request.is_main_frame = true;

request.parent_is_main_frame = false;

- request.parent_render_frame_id = -1;

request.transition_type = ui::PAGE_TRANSITION_LINK;

request.allow_download = true;

return request;