content/browser/loader/resource_dispatcher_host_impl.cc - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments #47 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/web_navigation.json ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | extensions/browser/api/web_request/web_request_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index bffd3d6f4f93af729c7da4a72ca24fc02e6a0fb9..830f2e369d105cd8745d4070d7a5c07290de862d 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -1178,8 +1178,7 @@ void ResourceDispatcherHostImpl::UpdateRequestForTransfer(

// ResourceRequestInfo rather than caching it locally. This lets us update

// the info object when a transfer occurs.

info->UpdateForTransfer(child_id, route_id, request_data.origin_pid,

- request_id, request_data.parent_render_frame_id,

- filter_->GetWeakPtr());

+ request_id, filter_->GetWeakPtr());

// Update maps that used the old IDs, if necessary. Some transfers in tests

// do not actually use a different ID, so not all maps need to be updated.

@@ -1410,7 +1409,6 @@ void ResourceDispatcherHostImpl::BeginRequest(

request_data.render_frame_id,

request_data.is_main_frame,

request_data.parent_is_main_frame,

- request_data.parent_render_frame_id,

request_data.resource_type,

request_data.transition_type,

request_data.should_replace_current_entry,

@@ -1707,7 +1705,6 @@ ResourceRequestInfoImpl* ResourceDispatcherHostImpl::CreateRequestInfo(

render_frame_route_id,

false, // is_main_frame

false, // parent_is_main_frame

- -1, // parent_render_frame_id

RESOURCE_TYPE_SUB_RESOURCE,

ui::PAGE_TRANSITION_LINK,

false, // should_replace_current_entry

@@ -2147,7 +2144,6 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(

request_id_,

-1, // request_data.render_frame_id,

info.is_main_frame, info.parent_is_main_frame,

- -1, // request_data.parent_render_frame_id,

resource_type, info.common_params.transition,

// should_replace_current_entry. This was only maintained at layer for

// request transfers and isn't needed for browser-side navigations.