chrome/test/data/extensions/api_test/messaging/connect/manifest.json - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/messaging/connect/manifest.json

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve port lifetime management, add tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/templates/intros/webNavigation.html ('K') | « chrome/test/data/extensions/api_test/messaging/connect/frame.js ('k') | chrome/test/data/extensions/api_test/messaging/connect/page.js » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/messaging/connect/manifest.json

diff --git a/chrome/test/data/extensions/api_test/messaging/connect/manifest.json b/chrome/test/data/extensions/api_test/messaging/connect/manifest.json

index abb898b8f03d2def83935310960c9afe754b927c..e9af6dbd8954f4165085f6e141604f71edddcdc3 100644

--- a/chrome/test/data/extensions/api_test/messaging/connect/manifest.json

+++ b/chrome/test/data/extensions/api_test/messaging/connect/manifest.json

@@ -15,7 +15,10 @@

{

"all_frames": true,

- "matches": ["http://*/*?testSendMessageFromFrame*"],

+ "matches": [

+ "http://*/*?testSendMessageFromFrame*",

+ "http://*/*?testConnectChildFrameAndNavigate*"

+ ],

"js": ["frame.js"]

}

]