chrome/renderer/extensions/tabs_custom_bindings.cc - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/tabs_custom_bindings.cc

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve port lifetime management, add tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/tabs_custom_bindings.cc

diff --git a/chrome/renderer/extensions/tabs_custom_bindings.cc b/chrome/renderer/extensions/tabs_custom_bindings.cc

index 93576960e5049bba71a167b4fe560111fe8490a0..efc5f26efcb54ade457a327be951d7da86877fe4 100644

--- a/chrome/renderer/extensions/tabs_custom_bindings.cc

+++ b/chrome/renderer/extensions/tabs_custom_bindings.cc

@@ -47,7 +47,8 @@ void TabsCustomBindings::OpenChannelToTab(

std::string channel_name = *v8::String::Utf8Value(args[3]);

int port_id = -1;

render_frame->Send(new ExtensionHostMsg_OpenChannelToTab(

- info, extension_id, channel_name, &port_id));

+ render_frame->GetRoutingID(), info, extension_id, channel_name,

+ &port_id));

args.GetReturnValue().Set(static_cast<int32_t>(port_id));

}