Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3846)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/api/web_navigation.json

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add override specifier to destructor Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/messaging/message_service.h ('K') | « chrome/browser/renderer_host/chrome_extension_message_filter.cc ('k') | chrome/common/extensions/docs/templates/intros/webNavigation.html » ('j') | chrome/common/extensions/docs/templates/intros/webNavigation.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/web_navigation.json
diff --git a/chrome/common/extensions/api/web_navigation.json b/chrome/common/extensions/api/web_navigation.json
index fb79b82f2555129ce461c0b2c6d1147d23b20414..7dd678c13bedc405e138235e6c835d7474cd9e9a 100644
--- a/chrome/common/extensions/api/web_navigation.json
+++ b/chrome/common/extensions/api/web_navigation.json
@@ -31,7 +31,12 @@
"description": "Information about the frame to retrieve information about.",
"properties": {
"tabId": { "type": "integer", "minimum": 0, "description": "The ID of the tab in which the frame is." },
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {
+ "type": "integer",
+ "optional": true,
+ "deprecated": "Frames are now uniquely identified by their frame ID; the process ID is no longer needed and therefore ignored.",
Devlin 2015/12/12 14:25:00 nitty nit: uniquely identified by tabId + frameID
robwu 2015/12/14 20:55:41 Done.
+ "description": "The ID of the process runs the renderer for this tab."
+ },
"frameId": { "type": "integer", "minimum": 0, "description": "The ID of the frame in the given tab." }
}
},
@@ -90,7 +95,7 @@
},
"processId": {
"type": "integer",
- "description": "The ID of the process runs the renderer for this tab."
+ "description": "The ID of the process runs the renderer for this frame."
},
"frameId": {
"type": "integer",
@@ -132,7 +137,7 @@
"properties": {
"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation is about to occur."},
"url": {"type": "string"},
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this frame."},
"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique for a given tab and process."},
"parentFrameId": {"type": "integer", "description": "ID of frame that wraps the frame. Set to -1 of no parent frame exists."},
"timeStamp": {"type": "number", "description": "The time when the browser was about to start the navigation, in milliseconds since the epoch."}
@@ -159,7 +164,7 @@
"properties": {
"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},
"url": {"type": "string"},
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this frame."},
"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},
"transitionType": {"$ref": "TransitionType", "description": "Cause of the navigation."},
"transitionQualifiers": {"type": "array", "description": "A list of transition qualifiers.", "items": {"$ref": "TransitionQualifier"}},
@@ -187,7 +192,7 @@
"properties": {
"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},
"url": {"type": "string"},
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this frame."},
"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},
"timeStamp": {"type": "number", "description": "The time when the page's DOM was fully constructed, in milliseconds since the epoch."}
}
@@ -213,7 +218,7 @@
"properties": {
"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},
"url": {"type": "string"},
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this frame."},
"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},
"timeStamp": {"type": "number", "description": "The time when the document finished loading, in milliseconds since the epoch."}
}
@@ -239,7 +244,7 @@
"properties": {
"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},
"url": {"type": "string"},
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this frame."},
"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},
"error": {"type": "string", "description": "The error description."},
"timeStamp": {"type": "number", "description": "The time when the error occurred, in milliseconds since the epoch."}
@@ -293,7 +298,7 @@
"properties": {
"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},
"url": {"type": "string"},
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this frame."},
"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},
"transitionType": {"$ref": "TransitionType", "description": "Cause of the navigation."},
"transitionQualifiers": {"type": "array", "description": "A list of transition qualifiers.", "items": {"$ref": "TransitionQualifier"}},
@@ -337,7 +342,7 @@
"properties": {
"tabId": {"type": "integer", "description": "The ID of the tab in which the navigation occurs."},
"url": {"type": "string"},
- "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this tab."},
+ "processId": {"type": "integer", "description": "The ID of the process runs the renderer for this frame."},
"frameId": {"type": "integer", "description": "0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe. Frame IDs are unique within a tab."},
"transitionType": {"$ref": "TransitionType", "description": "Cause of the navigation."},
"transitionQualifiers": {"type": "array", "description": "A list of transition qualifiers.", "items": {"$ref": "TransitionQualifier"}},
« chrome/browser/extensions/api/messaging/message_service.h ('K') | « chrome/browser/renderer_host/chrome_extension_message_filter.cc ('k') | chrome/common/extensions/docs/templates/intros/webNavigation.html » ('j') | chrome/common/extensions/docs/templates/intros/webNavigation.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698