chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/message_service.cc ('K') | « chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc ('k') | chrome/browser/extensions/extension_messages_apitest.cc » ('j') | chrome/test/data/extensions/api_test/messaging/connect_crash/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index 3934405205658353b5314462b3981771d3b9478b..12ff152da8ccc739887186d5df1641db9c8b7f5b 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -42,6 +42,7 @@

#include "content/public/common/resource_type.h"

#include "content/public/common/url_constants.h"

#include "content/public/test/browser_test_utils.h"

+#include "content/public/test/test_utils.h"

#include "extensions/browser/extension_system.h"

#include "extensions/common/switches.h"

#include "extensions/test/result_catcher.h"

@@ -737,6 +738,12 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, CrossProcessHistory) {

<< message_;

}

+IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, CrossProcessIframe) {

+ content::IsolateAllSitesForTesting(base::CommandLine::ForCurrentProcess());

+ ASSERT_TRUE(StartEmbeddedTestServer());

+ ASSERT_TRUE(RunExtensionTest("webnavigation/crossProcessIframe")) << message_;

// TODO(jam): http://crbug.com/350550

#if !(defined(OS_CHROMEOS) && defined(ADDRESS_SANITIZER))

IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Crash) {