extensions/browser/api/web_request/web_request_api_constants.cc - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api_constants.cc

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Charlie's nits (#33) Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_request/web_request_api_constants.cc

diff --git a/extensions/browser/api/web_request/web_request_api_constants.cc b/extensions/browser/api/web_request/web_request_api_constants.cc

index 4bc0c0ee16d4d7825bf30d0ab7e0393267214adc..fd10ca182dfa79d7d66fefe362e0249790a6b7a3 100644

--- a/extensions/browser/api/web_request/web_request_api_constants.cc

+++ b/extensions/browser/api/web_request/web_request_api_constants.cc

@@ -10,6 +10,7 @@ const char kChallengerKey[] = "challenger";

const char kErrorKey[] = "error";

const char kFrameIdKey[] = "frameId";

const char kParentFrameIdKey[] = "parentFrameId";

+const char kProcessIdKey[] = "processId";

const char kFromCache[] = "fromCache";

const char kHostKey[] = "host";

const char kIpKey[] = "ip";