Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/framework.js

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits in #16, s/FindByFrameTreeNodeID/FindFrameByFrameTreeNodeID/ Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/frame.js ('K') | « chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/frame.js ('k') | chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/main.html » ('j') | chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var deepEq = chrome.test.checkDeepEq; 5 var deepEq = chrome.test.checkDeepEq;
6 var expectedEventData; 6 var expectedEventData;
7 var expectedEventOrder; 7 var expectedEventOrder;
8 var capturedEventData; 8 var capturedEventData;
9 var nextFrameId; 9 var nextFrameId;
10 var frameIds; 10 var frameIds;
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 return [ main_frame + "onCommitted", 254 return [ main_frame + "onCommitted",
255 iframe + "onBeforeNavigate", 255 iframe + "onBeforeNavigate",
256 iframe + "onCompleted", 256 iframe + "onCompleted",
257 main_frame + "onCompleted" ]; 257 main_frame + "onCompleted" ];
258 } 258 }
259 259
260 // Returns the constraint expressing that a frame was loaded by another. 260 // Returns the constraint expressing that a frame was loaded by another.
261 function isLoadedBy(target, source) { 261 function isLoadedBy(target, source) {
262 return [ source + "onDOMContentLoaded", target + "onBeforeNavigate"]; 262 return [ source + "onDOMContentLoaded", target + "onBeforeNavigate"];
263 } 263 }
OLDNEW
« chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/frame.js ('K') | « chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/frame.js ('k') | chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/main.html » ('j') | chrome/test/data/extensions/api_test/webnavigation/crossProcessIframe/test_crossProcessIframe.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698