Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1413543004: Extract WorldImpactBuilder from _ResolutionWorldImpact. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract WorldImpactBuilder from _ResolutionWorldImpact. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/c3d8f392c5a9d39babe619110a00fcc06723eebd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -163 lines) Patch
M pkg/compiler/lib/src/resolution/registry.dart View 3 chunks +3 lines, -163 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 2 chunks +157 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 2 months ago (2015-10-19 11:02:33 UTC) #2
sigurdm
LGTM
5 years, 2 months ago (2015-10-19 11:55:23 UTC) #3
Johnni Winther
5 years, 2 months ago (2015-10-19 12:31:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3d8f392c5a9d39babe619110a00fcc06723eebd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698