Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: ppapi/tests/test_view.cc

Issue 1413523007: Simplify computation of the invalidation rect for a frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/tests/test_view.cc
diff --git a/ppapi/tests/test_view.cc b/ppapi/tests/test_view.cc
index 8239b037dec79344fb80f4bfeb13b0ae8c27a0f4..f8c20d8723056896ce0bfa98de2de1ebfd816276 100644
--- a/ppapi/tests/test_view.cc
+++ b/ppapi/tests/test_view.cc
@@ -142,8 +142,8 @@ std::string TestView::TestClipChange() {
// Original clip should be the full frame.
pp::Rect original_clip = last_view_.GetClipRect();
- ASSERT_TRUE(original_clip.x() == 0);
- ASSERT_TRUE(original_clip.y() == 0);
+ ASSERT_TRUE(original_clip.x() == 1);
+ ASSERT_TRUE(original_clip.y() == 1);
ASSERT_TRUE(original_clip.width() == original_rect.width());
ASSERT_TRUE(original_clip.height() == original_rect.height());
@@ -164,8 +164,9 @@ std::string TestView::TestClipChange() {
instance_->EvalScript(script_stream.str());
pp::Rect desired_clip = original_clip;
- desired_clip.set_y(clip_amount);
- desired_clip.set_height(desired_clip.height() - desired_clip.y());
+ desired_clip.set_y(clip_amount + original_clip.y());
+ desired_clip.set_height(
+ desired_clip.height() - desired_clip.y() + original_clip.y());
while (WaitUntilViewChanged() && last_view_.GetClipRect() != desired_clip) {
}
« no previous file with comments | « chrome/test/data/nacl/ppapi/ppp_instance/ppapi_ppp_instance.cc ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698