third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp - Issue 1413523007: Simplify computation of the invalidation rect for a frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

Issue 1413523007: Simplify computation of the invalidation rect for a frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerClipper.h ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.h » ('j') | third_party/WebKit/Source/web/WebPluginContainerImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

index c3eddeeed88edb799b2a6ed772320716b6c6a302..1fc520f13225eab4b812b880ceb86b70d818960b 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

@@ -172,6 +172,7 @@ void PaintLayerClipper::clearClipRectsIncludingDescendants(ClipRectsCacheSlot ca

LayoutRect PaintLayerClipper::childrenClipRect() const

{

+ DisableCompositingQueryAsserts disabler;

tommycli 2015/11/03 20:10:22 Previous usage of this had this comment: // FIXME

chrishtr 2015/11/03 21:24:56 Forgot to update in the latest patchset. This meth

// FIXME: border-radius not accounted for.

// FIXME: Flow thread based columns not accounted for.

PaintLayer* clippingRootLayer = clippingRootForPainting();