Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1413513009: Use mocked scrollbar in webkit unit tests (Closed)

Created:
5 years, 1 month ago by Xianzhu
Modified:
5 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use mocked scrollbar in webkit unit tests A webkit unit test will crash in chromium code if a scrollbar using native theme is painted, because the required resources are not loaded in webkit unit tests. Synchronized painting would cause some unit tests previously didn't crash to crash. Use mocked scrollbar for these unit tests. BUG=536999 Committed: https://crrev.com/2cfdf53e287eac60d29e58002fbe35d81977184a Cr-Commit-Position: refs/heads/master@{#356997}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 9 (2 generated)
Xianzhu
schenney@ I was told you are planning to remove mocked scrollbars. This CL added usages ...
5 years, 1 month ago (2015-10-29 22:56:23 UTC) #2
chrishtr
https://codereview.chromium.org/1413513009/diff/1/third_party/WebKit/Source/web/tests/WebFrameTest.cpp File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (left): https://codereview.chromium.org/1413513009/diff/1/third_party/WebKit/Source/web/tests/WebFrameTest.cpp#oldcode943 third_party/WebKit/Source/web/tests/WebFrameTest.cpp:943: UseMockScrollbarSettings mockScrollbarSettings; Why remove all these?
5 years, 1 month ago (2015-10-29 23:08:43 UTC) #3
Xianzhu
https://codereview.chromium.org/1413513009/diff/1/third_party/WebKit/Source/web/tests/WebFrameTest.cpp File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (left): https://codereview.chromium.org/1413513009/diff/1/third_party/WebKit/Source/web/tests/WebFrameTest.cpp#oldcode943 third_party/WebKit/Source/web/tests/WebFrameTest.cpp:943: UseMockScrollbarSettings mockScrollbarSettings; On 2015/10/29 23:08:43, chrishtr wrote: > Why ...
5 years, 1 month ago (2015-10-29 23:40:28 UTC) #4
chrishtr
lgtm
5 years, 1 month ago (2015-10-30 00:16:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413513009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413513009/1
5 years, 1 month ago (2015-10-30 00:17:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 00:22:33 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 00:23:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cfdf53e287eac60d29e58002fbe35d81977184a
Cr-Commit-Position: refs/heads/master@{#356997}

Powered by Google App Engine
This is Rietveld 408576698