Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1413513003: Add a preloaded (wrong) HPKP pin for pinning-test.badssl.com (Closed)

Created:
5 years, 2 months ago by lgarron
Modified:
5 years, 2 months ago
Reviewers:
agl
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a preloaded (wrong) HPKP pin for pinning-test.badssl.com BUG= TEST=Visit https://pinning-test.badssl.com/ and check that you get an interstitial with a pinning failure (NET::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN). TBR=agl@chromium.org Committed: https://crrev.com/7ab20ca079fd882204bb338961a9eb0049973c1f Cr-Commit-Position: refs/heads/master@{#355950}

Patch Set 1 #

Patch Set 2 : Remove extra file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1377 lines, -1372 lines) Patch
M net/http/transport_security_state_static.h View 2 chunks +1373 lines, -1370 lines 0 comments Download
M net/http/transport_security_state_static.json View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413513003/1
5 years, 2 months ago (2015-10-23 22:32:33 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112397)
5 years, 2 months ago (2015-10-23 22:41:38 UTC) #5
lgarron
I can't tell why the presubmit failed (it says the OWNERS check was skipped). agl@, ...
5 years, 2 months ago (2015-10-23 23:54:34 UTC) #7
lgarron
On 2015/10/23 at 23:54:34, lgarron wrote: > I can't tell why the presubmit failed (it ...
5 years, 2 months ago (2015-10-23 23:54:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413513003/20001
5 years, 2 months ago (2015-10-23 23:59:01 UTC) #10
agl
lgtm
5 years, 2 months ago (2015-10-24 00:48:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-24 01:42:10 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-24 01:43:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ab20ca079fd882204bb338961a9eb0049973c1f
Cr-Commit-Position: refs/heads/master@{#355950}

Powered by Google App Engine
This is Rietveld 408576698