src/counters.h - Issue 1413503007: Provide a counter for thrown JavaScript errors per context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/counters.h

Issue 1413503007: Provide a counter for thrown JavaScript errors per context (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Per context counting implemented Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/counters.h

diff --git a/src/counters.h b/src/counters.h

index 9dff765dca0d18c3de01a663c98b3a142d95dc2b..895eb690a6b781fbd4503400b516862219e5d797 100644

--- a/src/counters.h

+++ b/src/counters.h

@@ -483,7 +483,8 @@ double AggregatedMemoryHistogram<Histogram>::Aggregate(double current_ms,

HR(gc_idle_time_limit_overshot, V8.GCIdleTimeLimit.Overshot, 0, 10000, 101) \

HR(gc_idle_time_limit_undershot, V8.GCIdleTimeLimit.Undershot, 0, 10000, \

101) \

- HR(code_cache_reject_reason, V8.CodeCacheRejectReason, 1, 6, 6)

+ HR(code_cache_reject_reason, V8.CodeCacheRejectReason, 1, 6, 6) \

+ HR(exceptions_thrown_per_context, V8.ExceptionsThrownPerContext, -1, 200, 202)

jochen (gone - plz use gerrit) 2015/10/29 14:37:07 I'd use a non-linear histogram. 202 buckets is qui

Michael Hablich 2015/10/29 15:23:34 I adapted it. I think this needs further tuning. I

#define HISTOGRAM_TIMER_LIST(HT) \

/* Garbage collection timers. */ \

« src/contexts.cc ('K') | « src/contexts.cc ('k') | src/isolate.cc » ('j') | src/isolate.cc » ('J')