Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1413503006: [test] Re-enable mjsunit/constant-folding-2 test that no longer fails. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Re-enable mjsunit/constant-folding-2 test that no longer fails. R=jarin@chromium.org BUG=v8:4506 LOG=n Committed: https://crrev.com/b7985aaeb749d1f8a66d1a14fa30c3c1218c830d Cr-Commit-Position: refs/heads/master@{#31455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-22 07:33:26 UTC) #1
Benedikt Meurer
Hey Jaro, Bug fixed. Re-enabling the test. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-22 07:34:02 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-22 08:22:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413503006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413503006/1
5 years, 2 months ago (2015-10-22 08:32:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 08:45:51 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 08:46:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7985aaeb749d1f8a66d1a14fa30c3c1218c830d
Cr-Commit-Position: refs/heads/master@{#31455}

Powered by Google App Engine
This is Rietveld 408576698