cc: Add software renderer pixel tests

cc/output/renderer_pixeltest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "cc/output/gl_renderer.h"
-
 #include "base/message_loop.h"
 #include "cc/layers/append_quads_data.h"
+#include "cc/output/gl_renderer.h"
 #include "cc/quads/draw_quad.h"
 #include "cc/resources/sync_point_helper.h"
 #include "cc/test/pixel_test.h"
 #include "gpu/GLES2/gl2extchromium.h"
 #include "third_party/skia/include/core/SkImageFilter.h"
 #include "third_party/skia/include/core/SkMatrix.h"
 #include "third_party/skia/include/effects/SkColorFilterImageFilter.h"
 #include "third_party/skia/include/effects/SkColorMatrixFilter.h"
 
 namespace cc {
 namespace {
 
-class GLRendererPixelTest : public PixelTest {};
-
 scoped_ptr<RenderPass> CreateTestRootRenderPass(RenderPass::Id id,
                                                 gfx::Rect rect) {
   scoped_ptr<RenderPass> pass = RenderPass::Create();
   const gfx::Rect output_rect = rect;
   const gfx::RectF damage_rect = rect;
   const gfx::Transform transform_to_root_target;
   pass->SetNew(id, output_rect, damage_rect, transform_to_root_target);
   return pass.Pass();
 }
 
@@ skipping 35 matching lines @@
                0,             // mask_resource_id
                rect,          // contents_changed_since_last_frame
                gfx::RectF(),  // mask_uv_rect
                WebKit::WebFilterOperations(),   // foreground filters
                skia::RefPtr<SkImageFilter>(),   // foreground filter
                WebKit::WebFilterOperations());  // background filters
 
   return quad.PassAs<DrawQuad>();
 }
 
+typedef ::testing::Types<GLRenderer, SoftwareRenderer> RendererTypes;
+TYPED_TEST_CASE(RendererPixelTest, RendererTypes);
+
+// All pixels can be off by one, but any more than that is an error.
+class FuzzyPixelOffByOneComparator : public FuzzyPixelComparator {
+ public:
+  explicit FuzzyPixelOffByOneComparator(bool discard_alpha)
+    : FuzzyPixelComparator(discard_alpha, 100.f, 0.f, 1.f, 1, 0) {}
+};
 
 #if !defined(OS_ANDROID)
-TEST_F(GLRendererPixelTest, SimpleGreenRect) {
-  gfx::Rect rect(device_viewport_size_);
+TYPED_TEST(RendererPixelTest, SimpleGreenRect) {
+  gfx::Rect rect(this->device_viewport_size_);

[enne (OOO), 2013/04/28 02:56:55]

The "this->" requirement is an unfortunate requirement of derived class
templates.

 
   RenderPass::Id id(1, 1);
   scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
 
   gfx::Transform content_to_target_transform;
   scoped_ptr<SharedQuadState> shared_state =
       CreateTestSharedQuadState(content_to_target_transform, rect);
 
   scoped_ptr<SolidColorDrawQuad> color_quad = SolidColorDrawQuad::Create();
   color_quad->SetNew(shared_state.get(), rect, SK_ColorGREEN);
 
   pass->quad_list.push_back(color_quad.PassAs<DrawQuad>());
 
   RenderPassList pass_list;
   pass_list.push_back(pass.Pass());
 
-  EXPECT_TRUE(RunPixelTest(
+  EXPECT_TRUE(this->RunPixelTest(
       &pass_list,
       base::FilePath(FILE_PATH_LITERAL("green.png")),
       ExactPixelComparator(true)));
 }
 
-TEST_F(GLRendererPixelTest, FastPassColorFilterAlpha) {
-  gfx::Rect viewport_rect(device_viewport_size_);
+TYPED_TEST(RendererPixelTest, FastPassColorFilterAlpha) {
+  gfx::Rect viewport_rect(this->device_viewport_size_);
 
   RenderPass::Id root_pass_id(1, 1);
   scoped_ptr<RenderPass> root_pass =
       CreateTestRootRenderPass(root_pass_id, viewport_rect);
 
   RenderPass::Id child_pass_id(2, 2);
-  gfx::Rect pass_rect(device_viewport_size_);
+  gfx::Rect pass_rect(this->device_viewport_size_);
   gfx::Transform transform_to_root;
   scoped_ptr<RenderPass> child_pass =
       CreateTestRenderPass(child_pass_id, pass_rect, transform_to_root);
 
   gfx::Transform content_to_target_transform;
   scoped_ptr<SharedQuadState> shared_state =
       CreateTestSharedQuadState(content_to_target_transform, viewport_rect);
   shared_state->opacity = 0.5f;
 
   scoped_ptr<SolidColorDrawQuad> blue = SolidColorDrawQuad::Create();
   blue->SetNew(shared_state.get(),
                gfx::Rect(0,
                          0,
-                         device_viewport_size_.width() / 2,
-                         device_viewport_size_.height()),
+                         this->device_viewport_size_.width() / 2,
+                         this->device_viewport_size_.height()),
                SK_ColorBLUE);
   scoped_ptr<SolidColorDrawQuad> yellow = SolidColorDrawQuad::Create();
   yellow->SetNew(shared_state.get(),
-                 gfx::Rect(device_viewport_size_.width() / 2,
+                 gfx::Rect(this->device_viewport_size_.width() / 2,
                            0,
-                           device_viewport_size_.width() / 2,
-                           device_viewport_size_.height()),
+                           this->device_viewport_size_.width() / 2,
+                           this->device_viewport_size_.height()),
                  SK_ColorYELLOW);
 
   scoped_ptr<SharedQuadState> blank_state =
       CreateTestSharedQuadState(content_to_target_transform, viewport_rect);
 
   scoped_ptr<SolidColorDrawQuad> white = SolidColorDrawQuad::Create();
   white->SetNew(blank_state.get(),
                 viewport_rect,
                 SK_ColorWHITE);
 
@@ skipping 37 matching lines @@
                            WebKit::WebFilterOperations(),
                            filter,
                            WebKit::WebFilterOperations());
 
   root_pass->quad_list.push_back(render_pass_quad.PassAs<DrawQuad>());
 
   RenderPassList pass_list;
   pass_list.push_back(child_pass.Pass());
   pass_list.push_back(root_pass.Pass());
 
-  EXPECT_TRUE(RunPixelTest(
+  // This test has alpha=254 for the software renderer vs. alpha=255 for the gl
+  // renderer so use a fuzzy comparator.
+  EXPECT_TRUE(this->RunPixelTest(
       &pass_list,
       base::FilePath(FILE_PATH_LITERAL("blue_yellow_alpha.png")),
-      ExactPixelComparator(false)));
+      FuzzyPixelOffByOneComparator(false)));
 }
 
-TEST_F(GLRendererPixelTest, FastPassColorFilterAlphaTranslation) {
-  gfx::Rect viewport_rect(device_viewport_size_);
+TYPED_TEST(RendererPixelTest, FastPassColorFilterAlphaTranslation) {
+  gfx::Rect viewport_rect(this->device_viewport_size_);
 
   RenderPass::Id root_pass_id(1, 1);
   scoped_ptr<RenderPass> root_pass =
       CreateTestRootRenderPass(root_pass_id, viewport_rect);
 
   RenderPass::Id child_pass_id(2, 2);
-  gfx::Rect pass_rect(device_viewport_size_);
+  gfx::Rect pass_rect(this->device_viewport_size_);
   gfx::Transform transform_to_root;
   scoped_ptr<RenderPass> child_pass =
       CreateTestRenderPass(child_pass_id, pass_rect, transform_to_root);
 
   gfx::Transform content_to_target_transform;
   scoped_ptr<SharedQuadState> shared_state =
       CreateTestSharedQuadState(content_to_target_transform, viewport_rect);
   shared_state->opacity = 0.5f;
 
   scoped_ptr<SolidColorDrawQuad> blue = SolidColorDrawQuad::Create();
   blue->SetNew(shared_state.get(),
                gfx::Rect(0,
                          0,
-                         device_viewport_size_.width() / 2,
-                         device_viewport_size_.height()),
+                         this->device_viewport_size_.width() / 2,
+                         this->device_viewport_size_.height()),
                SK_ColorBLUE);
   scoped_ptr<SolidColorDrawQuad> yellow = SolidColorDrawQuad::Create();
   yellow->SetNew(shared_state.get(),
-                 gfx::Rect(device_viewport_size_.width() / 2,
+                 gfx::Rect(this->device_viewport_size_.width() / 2,
                            0,
-                           device_viewport_size_.width() / 2,
-                           device_viewport_size_.height()),
+                           this->device_viewport_size_.width() / 2,
+                           this->device_viewport_size_.height()),
                  SK_ColorYELLOW);
 
   scoped_ptr<SharedQuadState> blank_state =
       CreateTestSharedQuadState(content_to_target_transform, viewport_rect);
 
   scoped_ptr<SolidColorDrawQuad> white = SolidColorDrawQuad::Create();
   white->SetNew(blank_state.get(),
                 viewport_rect,
                 SK_ColorWHITE);
 
@@ skipping 40 matching lines @@
                            WebKit::WebFilterOperations(),
                            filter,
                            WebKit::WebFilterOperations());
 
   root_pass->quad_list.push_back(render_pass_quad.PassAs<DrawQuad>());
   RenderPassList pass_list;
 
   pass_list.push_back(child_pass.Pass());
   pass_list.push_back(root_pass.Pass());
 
-  EXPECT_TRUE(RunPixelTest(
+  // This test has alpha=254 for the software renderer vs. alpha=255 for the gl
+  // renderer so use a fuzzy comparator.
+  EXPECT_TRUE(this->RunPixelTest(
       &pass_list,
       base::FilePath(FILE_PATH_LITERAL("blue_yellow_alpha_translate.png")),
-      ExactPixelComparator(false)));
+      FuzzyPixelOffByOneComparator(false)));
 }
 
-TEST_F(GLRendererPixelTest, RenderPassChangesSize) {
-  gfx::Rect viewport_rect(device_viewport_size_);
+TYPED_TEST(RendererPixelTest, RenderPassChangesSize) {
+  gfx::Rect viewport_rect(this->device_viewport_size_);
 
   RenderPass::Id root_pass_id(1, 1);
   scoped_ptr<RenderPass> root_pass =
       CreateTestRootRenderPass(root_pass_id, viewport_rect);
 
   RenderPass::Id child_pass_id(2, 2);
-  gfx::Rect pass_rect(device_viewport_size_);
+  gfx::Rect pass_rect(this->device_viewport_size_);
   gfx::Transform transform_to_root;
   scoped_ptr<RenderPass> child_pass =
       CreateTestRenderPass(child_pass_id, pass_rect, transform_to_root);
 
   gfx::Transform content_to_target_transform;
   scoped_ptr<SharedQuadState> shared_state =
       CreateTestSharedQuadState(content_to_target_transform, viewport_rect);
 
   scoped_ptr<SolidColorDrawQuad> blue = SolidColorDrawQuad::Create();
   blue->SetNew(shared_state.get(),
                gfx::Rect(0,
                          0,
-                         device_viewport_size_.width() / 2,
-                         device_viewport_size_.height()),
+                         this->device_viewport_size_.width() / 2,
+                         this->device_viewport_size_.height()),
                SK_ColorBLUE);
   scoped_ptr<SolidColorDrawQuad> yellow = SolidColorDrawQuad::Create();
   yellow->SetNew(shared_state.get(),
-                 gfx::Rect(device_viewport_size_.width() / 2,
+                 gfx::Rect(this->device_viewport_size_.width() / 2,
                            0,
-                           device_viewport_size_.width() / 2,
-                           device_viewport_size_.height()),
+                           this->device_viewport_size_.width() / 2,
+                           this->device_viewport_size_.height()),
                  SK_ColorYELLOW);
 
   child_pass->quad_list.push_back(blue.PassAs<DrawQuad>());
   child_pass->quad_list.push_back(yellow.PassAs<DrawQuad>());
 
   scoped_ptr<SharedQuadState> pass_shared_state =
       CreateTestSharedQuadState(gfx::Transform(), pass_rect);
   root_pass->quad_list.push_back(
       CreateTestRenderPassDrawQuad(pass_shared_state.get(),
                                    pass_rect,
                                    child_pass_id));
 
   RenderPassList pass_list;
   pass_list.push_back(child_pass.Pass());
   pass_list.push_back(root_pass.Pass());
 
-  renderer_->SetEnlargePassTextureAmountForTesting(gfx::Vector2d(50, 75));
+  this->renderer_->SetEnlargePassTextureAmountForTesting(gfx::Vector2d(50, 75));
 
-  EXPECT_TRUE(RunPixelTest(
+  EXPECT_TRUE(this->RunPixelTest(
       &pass_list,
       base::FilePath(FILE_PATH_LITERAL("blue_yellow.png")),
       ExactPixelComparator(true)));
 }
 
-class GLRendererPixelTestWithBackgroundFilter : public GLRendererPixelTest {
+template <typename RendererType>
+class RendererPixelTestWithBackgroundFilter
+    : public RendererPixelTest<RendererType> {
  protected:
   void SetUpRenderPassList() {
-    gfx::Rect device_viewport_rect(device_viewport_size_);
+    gfx::Rect device_viewport_rect(this->device_viewport_size_);
 
     RenderPass::Id root_id(1, 1);
     scoped_ptr<RenderPass> root_pass =
         CreateTestRootRenderPass(root_id, device_viewport_rect);
     root_pass->has_transparent_background = false;
 
     gfx::Transform identity_content_to_target_transform;
 
     RenderPass::Id filter_pass_id(2, 1);
     gfx::Transform transform_to_root;
@@ skipping 24 matching lines @@
       filter_pass_quad->SetNew(
           shared_state.get(),
           filter_pass_content_rect_,
           filter_pass_id,
           false,  // is_replica
           0,  // mask_resource_id
           filter_pass_content_rect_,  // contents_changed_since_last_frame
           gfx::RectF(),  // mask_uv_rect
           WebKit::WebFilterOperations(),  // filters
           skia::RefPtr<SkImageFilter>(),  // filter
-          background_filters_);
+          this->background_filters_);
       root_pass->quad_list.push_back(filter_pass_quad.PassAs<DrawQuad>());
       root_pass->shared_quad_state_list.push_back(shared_state.Pass());
     }
 
     const int kColumnWidth = device_viewport_rect.width() / 3;
 
     gfx::Rect left_rect = gfx::Rect(0, 0, kColumnWidth, 20);
     for (int i = 0; left_rect.y() < device_viewport_rect.height(); ++i) {
       scoped_ptr<SharedQuadState> shared_state =
           CreateTestSharedQuadState(identity_content_to_target_transform,
@@ skipping 43 matching lines @@
     pass_list_.push_back(filter_pass.Pass());
     pass_list_.push_back(root_pass.Pass());
   }
 
   RenderPassList pass_list_;
   WebKit::WebFilterOperations background_filters_;
   gfx::Transform filter_pass_to_target_transform_;
   gfx::Rect filter_pass_content_rect_;
 };
 
+typedef ::testing::Types<GLRenderer, SoftwareRenderer> RendererTypes;
+TYPED_TEST_CASE(RendererPixelTestWithBackgroundFilter, RendererTypes);
+
+typedef RendererPixelTestWithBackgroundFilter<GLRenderer>
+GLRendererPixelTestWithBackgroundFilter;
+
+// TODO(skaslev): The software renderer does not support filters yet.
 TEST_F(GLRendererPixelTestWithBackgroundFilter, InvertFilter) {
-  background_filters_.append(
+  this->background_filters_.append(
       WebKit::WebFilterOperation::createInvertFilter(1.f));
 
-  filter_pass_content_rect_ = gfx::Rect(device_viewport_size_);
-  filter_pass_content_rect_.Inset(12, 14, 16, 18);
+  this->filter_pass_content_rect_ = gfx::Rect(this->device_viewport_size_);
+  this->filter_pass_content_rect_.Inset(12, 14, 16, 18);
 
-  SetUpRenderPassList();
-  EXPECT_TRUE(RunPixelTest(
-      &pass_list_,
+  this->SetUpRenderPassList();
+  EXPECT_TRUE(this->RunPixelTest(
+      &this->pass_list_,
       base::FilePath(FILE_PATH_LITERAL("background_filter.png")),
       ExactPixelComparator(true)));
 }
 
+// Software renderer does not support anti-aliased edges.
 TEST_F(GLRendererPixelTest, AntiAliasing) {
   gfx::Rect rect(0, 0, 200, 200);
 
   RenderPass::Id id(1, 1);
   scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
 
   gfx::Transform red_content_to_target_transform;
   red_content_to_target_transform.Rotate(10);
   scoped_ptr<SharedQuadState> red_shared_state =
       CreateTestSharedQuadState(red_content_to_target_transform, rect);
@@ skipping 18 matching lines @@
       CreateTestSharedQuadState(blue_content_to_target_transform, rect);
 
   scoped_ptr<SolidColorDrawQuad> blue = SolidColorDrawQuad::Create();
   blue->SetNew(blue_shared_state.get(), rect, SK_ColorBLUE);
 
   pass->quad_list.push_back(blue.PassAs<DrawQuad>());
 
   RenderPassList pass_list;
   pass_list.push_back(pass.Pass());
 
-  EXPECT_TRUE(RunPixelTest(
+  EXPECT_TRUE(this->RunPixelTest(
       &pass_list,
       base::FilePath(FILE_PATH_LITERAL("anti_aliasing.png")),
       ExactPixelComparator(true)));
 }
 
+// This test tests that anti-aliasing works for axis aligned quads.
+// Anti-aliasing is only supported in the gl renderer.
 TEST_F(GLRendererPixelTest, AxisAligned) {
   gfx::Rect rect(0, 0, 200, 200);
 
   RenderPass::Id id(1, 1);
   gfx::Transform transform_to_root;
   scoped_ptr<RenderPass> pass =
       CreateTestRenderPass(id, rect, transform_to_root);
 
   gfx::Transform red_content_to_target_transform;
   red_content_to_target_transform.Translate(50, 50);
@@ skipping 24 matching lines @@
       CreateTestSharedQuadState(blue_content_to_target_transform, rect);
 
   scoped_ptr<SolidColorDrawQuad> blue = SolidColorDrawQuad::Create();
   blue->SetNew(blue_shared_state.get(), rect, SK_ColorBLUE);
 
   pass->quad_list.push_back(blue.PassAs<DrawQuad>());
 
   RenderPassList pass_list;
   pass_list.push_back(pass.Pass());
 
-  EXPECT_TRUE(RunPixelTest(
+  EXPECT_TRUE(this->RunPixelTest(
       &pass_list,
       base::FilePath(FILE_PATH_LITERAL("axis_aligned.png")),
       ExactPixelComparator(true)));
 }
 
 static void SyncPointCallback(int* callback_count) {
   ++(*callback_count);
   base::MessageLoop::current()->QuitWhenIdle();
 }
 
@@ skipping 53 matching lines @@
   base::MessageLoop::current()->Run();
 
   // The sync point should have happened.
   EXPECT_EQ(1, sync_point_callback_count);
   EXPECT_EQ(1, other_callback_count);
 }
 #endif
 
 }  // namespace
 }  // namespace cc