Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1413473005: Add TST(register, immediate) to ARM32 integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add TST(register, immediate) to ARM32 integrated assembler. Also cleans up instructions that use emitType01 to share more common code. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b81b90150e980671bc51e72c928ed0bad75bcd6a

Patch Set 1 #

Patch Set 2 : Fix conflict when merging into master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -132 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.h View 4 chunks +27 lines, -6 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 8 chunks +108 lines, -120 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/branch-mult-fwd.ll View 1 1 chunk +8 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/sdiv.ll View 1 chunk +8 lines, -1 line 0 comments Download
M tests_lit/assembler/arm32/udiv.ll View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-11-04 20:18:10 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-11-04 21:35:01 UTC) #4
Karl
5 years, 1 month ago (2015-11-04 22:54:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b81b90150e980671bc51e72c928ed0bad75bcd6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698