src/profiler/heap-snapshot-generator.cc - Issue 1413463006: Map v8::Object to v8::internal::JSReceiver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/heap-snapshot-generator.cc

Issue 1413463006: Map v8::Object to v8::internal::JSReceiver (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/heap-snapshot-generator.cc

diff --git a/src/profiler/heap-snapshot-generator.cc b/src/profiler/heap-snapshot-generator.cc

index e37f03df1b00394eaa99625c3a987b930ceb4c1b..d69b1ed47441c9de8c354799be2686550212f84d 100644

--- a/src/profiler/heap-snapshot-generator.cc

+++ b/src/profiler/heap-snapshot-generator.cc

@@ -2222,7 +2222,7 @@ void V8HeapExplorer::TagGlobalObjects() {

HandleScope scope(isolate);

Handle<JSGlobalObject> global_obj = enumerator.at(i);

urls[i] = global_object_name_resolver_->GetName(

- Utils::ToLocal(Handle<JSObject>::cast(global_obj)));

+ Utils::ReceiverToLocal(Handle<JSObject>::cast(global_obj)));

} else {

urls[i] = NULL;

}