content/browser/accessibility/site_per_process_accessibility_browsertest.cc - Issue 1413423003: Move some AX attrs from AXNodeData to AXTreeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

Issue 1413423003: Move some AX attrs from AXNodeData to AXTreeData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/one_shot_accessibility_tree_search_unittest.cc ('k') | content/browser/accessibility/snapshot_ax_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

diff --git a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

index 192b11c9efaaf304354e075de0e921448d87100f..647985ccf7127a41175ff01571dcc52efcc5e219 100644

--- a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

+++ b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

@@ -41,7 +41,7 @@ class SitePerProcessAccessibilityBrowserTest

bool AccessibilityTreeContainsDocTitle(

BrowserAccessibility* node,

const std::string& title) {

- if (node->GetStringAttribute(ui::AX_ATTR_DOC_TITLE) == title)

+ if (node->GetStringAttribute(ui::AX_ATTR_NAME) == title)

return true;

for (unsigned i = 0; i < node->PlatformChildCount(); i++) {

if (AccessibilityTreeContainsDocTitle(node->PlatformGetChild(i), title))

@@ -53,9 +53,8 @@ bool AccessibilityTreeContainsDocTitle(

// Utility function to determine if an accessibility tree has finished loading

// or if the tree represents a page that hasn't finished loading yet.

bool AccessibilityTreeIsLoaded(BrowserAccessibilityManager* manager) {

- BrowserAccessibility* root = manager->GetRoot();

- return (root->GetFloatAttribute(ui::AX_ATTR_DOC_LOADING_PROGRESS) == 1.0 &&

- root->GetStringAttribute(ui::AX_ATTR_DOC_URL) != url::kAboutBlankURL);

+ return (manager->GetTreeData().loading_progress == 1.0 &&

+ manager->GetTreeData().url != url::kAboutBlankURL);

}

// Times out on Android, not clear if it's an actual bug or just slow.