Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1413423003: Move some AX attrs from AXNodeData to AXTreeData. (Closed)

Created:
5 years, 2 months ago by dmazzoni
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, plundblad+watch_chromium.org, mlamouri+watch-content_chromium.org, aboxhall+watch_chromium.org, jam, creis+watch_chromium.org, nasko+codewatch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some AX attrs from AXNodeData to AXTreeData. Previously all accessibility attributes had to be stored in AXNodeData. The root of a tree had a lot of extra attributes that only applied to that node. This introduces AXTreeData, a simple serializable struct with the data that applies to the whole tree, including the title, url, loading progress, and selection information. Later it will include focus information too. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1273 lines, -751 lines) Patch
M chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/aura/accessibility/automation_manager_aura.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/aura/accessibility/ax_tree_source_aura.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/chrome_extension_messages.h View 3 chunks +20 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.h View 3 chunks +25 lines, -27 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 9 chunks +406 lines, -305 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 8 chunks +102 lines, -11 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_auralinux.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 2 chunks +9 lines, -9 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 7 chunks +10 lines, -8 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 12 chunks +26 lines, -17 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_auralinux.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_auralinux.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 6 chunks +40 lines, -25 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 2 chunks +22 lines, -14 lines 0 comments Download
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M content/browser/accessibility/one_shot_accessibility_tree_search_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/accessibility/snapshot_ax_tree_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +8 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 5 chunks +25 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/accessibility_messages.h View 2 chunks +22 lines, -3 lines 0 comments Download
M content/common/ax_content_node_data.h View 2 chunks +21 lines, -6 lines 0 comments Download
M content/common/ax_content_node_data.cc View 2 chunks +19 lines, -6 lines 0 comments Download
M content/public/browser/ax_event_notification_details.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 2 chunks +48 lines, -50 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/accessibility_browser_test_utils.cc View 1 chunk +1 line, -8 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 5 chunks +0 lines, -23 lines 0 comments Download
M ui/accessibility/ax_generated_tree_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/accessibility/ax_node_data.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_node_data.cc View 5 chunks +0 lines, -36 lines 0 comments Download
M ui/accessibility/ax_serializable_tree.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/accessibility/ax_serializable_tree.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/accessibility/ax_tree.h View 4 chunks +12 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree.cc View 3 chunks +13 lines, -4 lines 0 comments Download
A ui/accessibility/ax_tree_data.h View 1 chunk +60 lines, -0 lines 0 comments Download
A ui/accessibility/ax_tree_data.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_serializer.h View 14 chunks +66 lines, -47 lines 0 comments Download
M ui/accessibility/ax_tree_serializer_unittest.cc View 11 chunks +18 lines, -14 lines 0 comments Download
M ui/accessibility/ax_tree_source.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 18 chunks +68 lines, -20 lines 0 comments Download
M ui/accessibility/ax_tree_update.h View 4 chunks +27 lines, -11 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/tree_generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698