Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1413403009: Clean up GrBatchAtlas a bit (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up GrBatchAtlas a bit The main thrust of this CL is to remove knowledge of the atlas' backing texture from the BatchPlot. It also reduces the API surface of the BatchPlot and shrinks the amount of fields in the BatchAtlas. Committed: https://skia.googlesource.com/skia/+/2b0536f37aa8915b6f58dae0b88b18023cb04d17

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Fix assert #

Patch Set 4 : Fix bpp size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -136 lines) Patch
M src/gpu/GrBatchAtlas.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 1 2 3 10 chunks +116 lines, -129 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
robertphillips
5 years, 1 month ago (2015-11-05 19:02:38 UTC) #3
joshualitt
On 2015/11/05 19:02:38, robertphillips wrote: lgtm
5 years, 1 month ago (2015-11-05 19:28:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413403009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413403009/20001
5 years, 1 month ago (2015-11-05 20:57:01 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/2371) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 1 month ago (2015-11-05 20:57:59 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413403009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413403009/40001
5 years, 1 month ago (2015-11-06 17:49:03 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/3331)
5 years, 1 month ago (2015-11-06 17:49:43 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413403009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413403009/60001
5 years, 1 month ago (2015-11-06 19:08:01 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 19:19:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413403009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413403009/60001
5 years, 1 month ago (2015-11-06 20:19:23 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 22:10:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/2b0536f37aa8915b6f58dae0b88b18023cb04d17

Powered by Google App Engine
This is Rietveld 408576698