chrome/test/media_router/media_router_integration_ui_browsertest.cc - Issue 1413403003: [Media Router] Auto-close Media Router dialog after starting or stopping a session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/media_router/media_router_integration_ui_browsertest.cc

Issue 1413403003: [Media Router] Auto-close Media Router dialog after starting or stopping a session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/media_router/media_router_integration_browsertest.cc ('K') | « chrome/test/media_router/media_router_integration_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/media_router/media_router_integration_ui_browsertest.cc

diff --git a/chrome/test/media_router/media_router_integration_ui_browsertest.cc b/chrome/test/media_router/media_router_integration_ui_browsertest.cc

index 0f8cd37c5e10daa5dd6834c35e16cbcb97b091ec..b57d2316a2067247d0bed3e8cd7f6cc446dc0ced 100644

--- a/chrome/test/media_router/media_router_integration_ui_browsertest.cc

+++ b/chrome/test/media_router/media_router_integration_ui_browsertest.cc

@@ -33,6 +33,8 @@ IN_PROC_BROWSER_TEST_F(MediaRouterIntegrationBrowserTest, MANUAL_Dialog_Basic) {

ChooseSink(web_contents, kTestSinkName);

WaitUntilRouteCreated();

+ ClickDialog();

imcheng 2015/10/22 18:44:14 Add some comments explaining what this is doing, e

apacible 2015/10/23 18:03:11 Done.

+ CheckDialogIsOpen(web_contents);

// Verify the route details page.

std::string route_info_script = base::StringPrintf(

@@ -56,6 +58,7 @@ IN_PROC_BROWSER_TEST_F(MediaRouterIntegrationBrowserTest, MANUAL_Dialog_Basic) {

// Close route.

CloseRouteOnUI();

+ CheckDialogIsClosed(web_contents);

imcheng 2015/10/22 18:44:14 Same here.

apacible 2015/10/23 18:03:11 Done.

}

IN_PROC_BROWSER_TEST_F(MediaRouterIntegrationBrowserTest,

« chrome/test/media_router/media_router_integration_browsertest.cc ('K') | « chrome/test/media_router/media_router_integration_browsertest.cc ('k') | no next file » | no next file with comments »