[Media Router] Auto-close Media Router dialog after starting or stopping a session.

[Media Router] Auto-close Media Router dialog after starting or stopping a session.

The current behavior for the Media Router dialog is as follows:
- After starting a session successfully, the dialog switches to the route-details view but does nothing.
- After stopping a session, the dialog closes automatically.

The new behavior will be as follows:
- After starting a session successfully, or after stopping a session, the dialog waits three seconds for any user interaction before closing the dialog.

BUG=532694
Committed: https://crrev.com/4e89b635aeeaf74ae5af1041df98bf43541a4a84
Cr-Commit-Position: refs/heads/master@{#355962}

[apacible, 2015-10-20 20:53:15]

Patchset #1 (id:1) has been deleted

[apacible, 2015-10-20 20:53:23]

Description was changed from

==========
close dialog after start/stop session if no clicks after 3s

BUG=
==========

to

==========
close dialog after start/stop session if no clicks after 3s

BUG=532694
==========

[apacible, 2015-10-20 20:54:50]

Description was changed from

==========
close dialog after start/stop session if no clicks after 3s

BUG=532694
==========

to

==========
[Media Router] Auto-close Media Router dialog after casting starts or stops.

BUG=532694
==========

[apacible, 2015-10-20 21:26:58]

Description was changed from

==========
[Media Router] Auto-close Media Router dialog after casting starts or stops.

BUG=532694
==========

to

==========
[Media Router] Auto-close Media Router dialog after starting or stopping a
session.

BUG=532694
==========

[apacible, 2015-10-20 21:34:19]

Description was changed from

==========
[Media Router] Auto-close Media Router dialog after starting or stopping a
session.

BUG=532694
==========

to

==========
[Media Router] Auto-close Media Router dialog after starting or stopping a
session.

The current behavior for the Media Router dialog is as follows:
- After starting a session successfully, the dialog switches to the
route-details view but does nothing.
- After stopping a session, the dialog closes automatically.

The new behavior will be as follows:
- After starting a session successfully, or after stopping a session, the dialog
waits three seconds for any user interaction before closing the dialog. 

BUG=532694
==========

[apacible, 2015-10-22 16:54:23]

Patchset #1 (id:20001) has been deleted

[apacible, 2015-10-22 16:54:29]

Patchset #1 (id:40001) has been deleted

[apacible, 2015-10-22 16:54:34]

The CQ bit was checked by apacible@chromium.org to run a CQ dry run

[apacible, 2015-10-22 16:54:44]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2015-10-22 16:54:46]

PTAL, thanks!

[commit-bot: I haz the power, 2015-10-22 16:55:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413403003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413403003/60001

[commit-bot: I haz the power, 2015-10-22 17:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 17:04:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[imcheng, 2015-10-22 18:44:14]

https://codereview.chromium.org/1413403003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
(right):

https://codereview.chromium.org/1413403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:215:
this.addEventListener('close-route-click', this.startTapTimer_);
I see that there is also an event handler for close-route-click in the html file
(to navigate back to sink list) and also here to start the 3s timer. Would it be
possible to combine the two?

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:169: void
MediaRouterIntegrationBrowserTest::CheckDialogIsClosed(
naming suggestion: WaitUntilDialogClosed

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:177: void
MediaRouterIntegrationBrowserTest::CheckDialogIsOpen(
CheckDialogRemainsOpen

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_ui_browsertest.cc
(right):

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_ui_browsertest.cc:36:
ClickDialog();
Add some comments explaining what this is doing, e.g. simulate a click on the
dialog to prevent it from automatically closing after a route is created.

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_ui_browsertest.cc:61:
CheckDialogIsClosed(web_contents);
Same here.

[apacible, 2015-10-23 18:01:32]

Patchset #2 (id:80001) has been deleted

[apacible, 2015-10-23 18:02:41]

Patchset #2 (id:100001) has been deleted

[apacible, 2015-10-23 18:03:11]

https://codereview.chromium.org/1413403003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
(right):

https://codereview.chromium.org/1413403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:215:
this.addEventListener('close-route-click', this.startTapTimer_);
On 2015/10/22 18:44:14, imcheng1 wrote:
> I see that there is also an event handler for close-route-click in the html
file
> (to navigate back to sink list) and also here to start the 3s timer. Would it
be
> possible to combine the two?

Done.

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:169: void
MediaRouterIntegrationBrowserTest::CheckDialogIsClosed(
On 2015/10/22 18:44:14, imcheng1 wrote:
> naming suggestion: WaitUntilDialogClosed

Done.

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:177: void
MediaRouterIntegrationBrowserTest::CheckDialogIsOpen(
On 2015/10/22 18:44:14, imcheng1 wrote:
> CheckDialogRemainsOpen

Done.

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_ui_browsertest.cc
(right):

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_ui_browsertest.cc:36:
ClickDialog();
On 2015/10/22 18:44:14, imcheng1 wrote:
> Add some comments explaining what this is doing, e.g. simulate a click on the
> dialog to prevent it from automatically closing after a route is created.

Done.

https://codereview.chromium.org/1413403003/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_ui_browsertest.cc:61:
CheckDialogIsClosed(web_contents);
On 2015/10/22 18:44:14, imcheng1 wrote:
> Same here.

Done.

[imcheng, 2015-10-23 20:54:42]

lgtm

[apacible, 2015-10-24 04:01:11]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-10-24 04:01:12]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1413403003/#ps140001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-10-24 04:01:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413403003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413403003/140001

[commit-bot: I haz the power, 2015-10-24 04:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-24 04:11:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[apacible, 2015-10-24 05:13:01]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-10-24 05:13:01]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1413403003/#ps160001
(title: "Fix missed renaming.")

[commit-bot: I haz the power, 2015-10-24 05:13:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413403003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413403003/160001

[commit-bot: I haz the power, 2015-10-24 05:16:56]

Committed patchset #4 (id:160001)

[commit-bot: I haz the power, 2015-10-24 05:17:54]

Patchset 4 (id:??) landed as
https://crrev.com/4e89b635aeeaf74ae5af1041df98bf43541a4a84
Cr-Commit-Position: refs/heads/master@{#355962}

[nancyrod072315_gmail.com, 2015-10-24 05:34:13]

On 2015/10/24 05:17:54, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/4e89b635aeeaf74ae5af1041df98bf43541a4a84
> Cr-Commit-Position: refs/heads/master@{#355962}