Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: trace/service/traceservice.proto

Issue 1413403002: Add a Ping() method to the trace service to make it easier to detect if the service is up and runni… (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trace/service/impl.go ('k') | trace/service/traceservice.pb.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trace/service/traceservice.proto
diff --git a/trace/service/traceservice.proto b/trace/service/traceservice.proto
index cafbf0d7179bc9a6342182c18efc8b8d326e2699..ea68900f0055a52039cfb404ac3bc146caff2110 100644
--- a/trace/service/traceservice.proto
+++ b/trace/service/traceservice.proto
@@ -9,13 +9,13 @@ service TraceService {
rpc MissingParams(MissingParamsRequest) returns (MissingParamsResponse) {}
// Adds Params for a set of traceids.
- rpc AddParams(AddParamsRequest) returns (EmptyResponse) {}
+ rpc AddParams(AddParamsRequest) returns (Empty) {}
// Adds data for a set of traces for a particular commitid.
- rpc Add(AddRequest) returns (EmptyResponse) {}
+ rpc Add(AddRequest) returns (Empty) {}
// Removes data for a particular commitid.
- rpc Remove(RemoveRequest) returns (EmptyResponse) {}
+ rpc Remove(RemoveRequest) returns (Empty) {}
// List returns all the CommitIDs that exist in the given time range.
rpc List(ListRequest) returns (ListResponse) {}
@@ -25,9 +25,13 @@ service TraceService {
// GetParams returns the Params for all of the given traces.
rpc GetParams(GetParamsRequest) returns (GetParamsResponse) {}
+
+ // Ping should always succeed. Used to test if the service is up and
+ // running.
+ rpc Ping (GetParamsRequest) returns (Empty) {}
}
-message EmptyResponse {
+message Empty {
}
// CommitID identifies one commit, or trybot try.
« no previous file with comments | « trace/service/impl.go ('k') | trace/service/traceservice.pb.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698