Issue 1413403002: Add a Ping() method to the trace service to make it easier to detect if the service is up and runni…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413403002: Add a Ping() method to the trace service to make it easier to detect if the service is up and runni… (Closed)

Created:
5 years, 2 months ago by jcgregorio

Modified:
5 years, 2 months ago

Reviewers:
stephana

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/buildbot@master

Target Ref:
refs/heads/master

Project:
skiabuildbot

Visibility:
Public.

More Reviews

Description

Add a Ping() method to the trace service to make it easier to detect if the service is up and running. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/0da35dc68dced5d4b53954973e0a53fdfe254472

Patch Set 1 #

Patch Set 2 : tests #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -27 lines)			Patch
M	trace/service/impl.go	View		5 chunks	+10 lines, -6 lines	0 comments	Download
M	trace/service/traceservice.proto	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	trace/service/traceservice.pb.go	View		9 chunks	+46 lines, -17 lines	0 comments	Download
M	trace/service/traceservice_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413403002/20001

5 years, 2 months ago (2015-10-20 19:11:05 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-20 19:12:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/0da35dc68dced5d4b53954973e0a53fdfe25...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages