Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14134009: Roll Skia DEPS to r8756 (Closed)

Created:
7 years, 8 months ago by robertphillips
Modified:
7 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
chromium-reviews, skia-team_google.com
Visibility:
Public.

Description

Roll Skia DEPS to r8756 control: https://codereview.chromium.org/14221008/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
robertphillips
7 years, 8 months ago (2013-04-19 12:59:18 UTC) #1 
Basically got the regressions we expected.

The local DRT run had the following regressions while none of the trybots did:
  plugins/embed-attributes-style.html
  scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html

So I believe these were flakes from the local run.

The linux trybots have no regressions beyond what the local DRT had (which was
run on Linux) 

The mac trybots have the following regressions in addition to what the local DRT
run found:
	scrollbars/listbox-scrollbar-combinations.html
	virtual/gpu/compositedscrolling/scrollbars/listbox-scrollbar-combinations.html

Given that we see the following regressions on the Linux trybot (and local DRT):
	scrollbars/overflow-scrollbar-combinations.html
	virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations.html

I believe the listbox-scrollbar-combinations.html tests aren't run on Linux and
also need to be suppressed.

The raw discrepancies between the roll and control are:

mac_gpu
   roll:    
            content_browsertests failed 1
                MANUAL_BrowserPluginBlueBox
   control: 
            green

win_gpu
   roll:    
            content_browsertests failed 111
                MANUAL*
   control: 
            content_browsertests - timed out

linux_layout
   roll:    
            webkit_tests 1747 fixable (0 skipped) failed 24
              overflow-scrollbar-combinations.html 
              text-anchor-dirLTR-anchorEnd.svg 
              text-anchor-dirLTR-anchorMiddle.svg 
              text-anchor-dirLTR-anchorStart.svg 
              text-anchor-dirNone-anchorEnd.svg 
              text-anchor-dirNone-anchorMiddle.svg 
              text-anchor-dirNone-anchorStart.svg 
              text-anchor-dirRTL-anchorEnd.svg 
              text-anchor-dirRTL-anchorMiddle.svg 
              text-anchor-dirRTL-anchorStart.svg 
              text-anchor-inherited-dirLTR-anchorEnd.svg 
              text-anchor-inherited-dirLTR-anchorMiddle.svg 
              text-anchor-inherited-dirLTR-anchorStart.svg 
              text-anchor-inherited-dirRTL-anchorEnd.svg 
              text-anchor-inherited-dirRTL-anchorMiddle.svg 
              text-anchor-inherited-dirRTL-anchorStart.svg 
              text-anchor-no-markup.svg 
              image-preserveAspectRatio-all.svg 
              feTile.svg 
              image-small-width-height.svg 
              pointer-events-image-css-transform.svg 
              pointer-events-image.svg 
              feImage-preserveAspectRatio-all.svg 
              overflow-scrollbar-combinations.html 
   control: 
            webkit_tests 1783 fixable (0 skipped) failed 44
                - no matches with the failures in the roll

linux_layout_rel
   roll:    
            webkit_tests 1671 fixable (0 skipped) failed 88
                Unexpected text-only failures (35)
                Unexpected image-only failures (24) - that match linux_layout
                Unexpected timeouts (29)
   control: 
            green

mac_layout
   roll:    
            webkit_tests 1725 fixable (0 skipped) failed 26
                  listbox-scrollbar-combinations.html 
                  overflow-scrollbar-combinations.html 
                  text-anchor-dirLTR-anchorEnd.svg 
                  text-anchor-dirLTR-anchorMiddle.svg 
                  text-anchor-dirLTR-anchorStart.svg 
                  text-anchor-dirNone-anchorEnd.svg 
                  text-anchor-dirNone-anchorMiddle.svg 
                  text-anchor-dirNone-anchorStart.svg 
                  text-anchor-dirRTL-anchorEnd.svg 
                  text-anchor-dirRTL-anchorMiddle.svg 
                  text-anchor-dirRTL-anchorStart.svg 
                  text-anchor-inherited-dirLTR-anchorEnd.svg 
                  text-anchor-inherited-dirLTR-anchorMiddle.svg 
                  text-anchor-inherited-dirLTR-anchorStart.svg 
                  text-anchor-inherited-dirRTL-anchorEnd.svg 
                  text-anchor-inherited-dirRTL-anchorMiddle.svg 
                  text-anchor-inherited-dirRTL-anchorStart.svg 
                  text-anchor-no-markup.svg 
                  image-preserveAspectRatio-all.svg 
                  feTile.svg 
                  image-small-width-height.svg 
                  pointer-events-image-css-transform.svg 
                  pointer-events-image.svg 
                  feImage-preserveAspectRatio-all.svg 
                  listbox-scrollbar-combinations.html 
                  scrollbars/overflow-scrollbar-combinations.html 
   control: 
            green

mac_layout_rel
   roll:    
            webkit_tests 1565 fixable (0 skipped) failed 26
              listbox-scrollbar-combinations.html 
              overflow-scrollbar-combinations.html 
              text-anchor-dirLTR-anchorEnd.svg 
              text-anchor-dirLTR-anchorMiddle.svg 
              text-anchor-dirLTR-anchorStart.svg 
              text-anchor-dirNone-anchorEnd.svg 
              text-anchor-dirNone-anchorMiddle.svg 
              text-anchor-dirNone-anchorStart.svg 
              text-anchor-dirRTL-anchorEnd.svg 
              text-anchor-dirRTL-anchorMiddle.svg 
              text-anchor-dirRTL-anchorStart.svg 
              text-anchor-inherited-dirLTR-anchorEnd.svg 
              text-anchor-inherited-dirLTR-anchorMiddle.svg 
              text-anchor-inherited-dirLTR-anchorStart.svg 
              text-anchor-inherited-dirRTL-anchorEnd.svg 
              text-anchor-inherited-dirRTL-anchorMiddle.svg 
              text-anchor-inherited-dirRTL-anchorStart.svg 
              text-anchor-no-markup.svg 
              image-preserveAspectRatio-all.svg 
              feTile.svg 
              image-small-width-height.svg 
              pointer-events-image-css-transform.svg 
              pointer-events-image.svg 
              feImage-preserveAspectRatio-all.svg 
              listbox-scrollbar-combinations.html 
              overflow-scrollbar-combinations.html 
   control: 
            green

win_layout
   roll:    
            gclient hooks failed
   control: 
            gclient hooks failed

win_layout_rel
   roll:    
            compile failed  
            - 'inChildFrameLayoutWithFrameFlattening' undeclared identifier
   control: 
            green

Powered by Google App Engine
This is Rietveld 408576698